diff options
| author | Yang Yingliang <yangyingliang@huawei.com> | 2020-07-14 14:56:39 +0000 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2020-07-29 10:16:47 +0200 |
| commit | 5a987f7ba02c97c731a1a96e148910b54734ebea (patch) | |
| tree | f4a6503475f4524cac09b7d7512117f913d0dd9d /drivers/infiniband/core | |
| parent | 675f4bbcd68330d2d0c96e1f716886727ad7dd1a (diff) | |
| download | linux-5a987f7ba02c97c731a1a96e148910b54734ebea.tar.gz linux-5a987f7ba02c97c731a1a96e148910b54734ebea.tar.bz2 linux-5a987f7ba02c97c731a1a96e148910b54734ebea.zip | |
IB/umem: fix reference count leak in ib_umem_odp_get()
Add missing mmput() on error path to avoid ref-count leak.
This problem is introduced by 79bb5b7ee177 ("RDMA/umem: Fix missing mmap_sem in get umem ODP call")
and resolved by f27a0d50a4bc ("RDMA/umem: Use umem->owning_mm inside ODP").
So, it's only needed in stable-4.14 and stable-4.19.
Fixes: 79bb5b7ee177 ("RDMA/umem: Fix missing mmap_sem in get umem ODP call")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/infiniband/core')
| -rw-r--r-- | drivers/infiniband/core/umem_odp.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/infiniband/core/umem_odp.c b/drivers/infiniband/core/umem_odp.c index 4bda1242df87..fd6ec56c17f9 100644 --- a/drivers/infiniband/core/umem_odp.c +++ b/drivers/infiniband/core/umem_odp.c @@ -356,7 +356,8 @@ int ib_umem_odp_get(struct ib_ucontext *context, struct ib_umem *umem, vma = find_vma(mm, ib_umem_start(umem)); if (!vma || !is_vm_hugetlb_page(vma)) { up_read(&mm->mmap_sem); - return -EINVAL; + ret_val = -EINVAL; + goto out_mm; } h = hstate_vma(vma); umem->page_shift = huge_page_shift(h); |