diff options
| author | Pan Bian <bianpan2016@163.com> | 2019-11-06 14:23:54 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2020-10-01 13:14:27 +0200 |
| commit | 14d73b6a1183f8573fae64996f3a7ccadcee9a33 (patch) | |
| tree | 0f78224c015dfa67804f7db6f4c88b0b104f6dd3 /drivers/infiniband | |
| parent | 515184695862ef58560603e105dc311138bd0e04 (diff) | |
| download | linux-14d73b6a1183f8573fae64996f3a7ccadcee9a33.tar.gz linux-14d73b6a1183f8573fae64996f3a7ccadcee9a33.tar.bz2 linux-14d73b6a1183f8573fae64996f3a7ccadcee9a33.zip | |
RDMA/qedr: Fix potential use after free
[ Upstream commit 960657b732e1ce21b07be5ab48a7ad3913d72ba4 ]
Move the release operation after error log to avoid possible use after
free.
Link: https://lore.kernel.org/r/1573021434-18768-1-git-send-email-bianpan2016@163.com
Signed-off-by: Pan Bian <bianpan2016@163.com>
Acked-by: Michal Kalderon <michal.kalderon@marvell.com>
Reviewed-by: Jason Gunthorpe <jgg@mellanox.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/infiniband')
| -rw-r--r-- | drivers/infiniband/hw/qedr/qedr_iw_cm.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/infiniband/hw/qedr/qedr_iw_cm.c b/drivers/infiniband/hw/qedr/qedr_iw_cm.c index 256671577367..e908dfbaa137 100644 --- a/drivers/infiniband/hw/qedr/qedr_iw_cm.c +++ b/drivers/infiniband/hw/qedr/qedr_iw_cm.c @@ -460,10 +460,10 @@ qedr_addr6_resolve(struct qedr_dev *dev, if ((!dst) || dst->error) { if (dst) { - dst_release(dst); DP_ERR(dev, "ip6_route_output returned dst->error = %d\n", dst->error); + dst_release(dst); } return -EINVAL; } |