summaryrefslogtreecommitdiff
path: root/drivers/infiniband
diff options
context:
space:
mode:
authorWang Wensheng <wangwensheng4@huawei.com>2021-04-08 11:31:40 +0000
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2021-05-14 09:44:28 +0200
commit05692b9523654ab48174dda83617ea45a3734fd5 (patch)
treea5c1ded5bba766dcf60e1c2ec56fb29e302928ec /drivers/infiniband
parent53656a2a01834e3d90fb2813ae5c82febcb96218 (diff)
downloadlinux-05692b9523654ab48174dda83617ea45a3734fd5.tar.gz
linux-05692b9523654ab48174dda83617ea45a3734fd5.tar.bz2
linux-05692b9523654ab48174dda83617ea45a3734fd5.zip
IB/hfi1: Fix error return code in parse_platform_config()
[ Upstream commit 4c7d9c69adadfc31892c7e8e134deb3546552106 ] Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: 7724105686e7 ("IB/hfi1: add driver files") Link: https://lore.kernel.org/r/20210408113140.103032-1-wangwensheng4@huawei.com Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Wang Wensheng <wangwensheng4@huawei.com> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/infiniband')
-rw-r--r--drivers/infiniband/hw/hfi1/firmware.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/infiniband/hw/hfi1/firmware.c b/drivers/infiniband/hw/hfi1/firmware.c
index 2b57ba70ddd6..c09080712485 100644
--- a/drivers/infiniband/hw/hfi1/firmware.c
+++ b/drivers/infiniband/hw/hfi1/firmware.c
@@ -1924,6 +1924,7 @@ int parse_platform_config(struct hfi1_devdata *dd)
dd_dev_err(dd, "%s: Failed CRC check at offset %ld\n",
__func__, (ptr -
(u32 *)dd->platform_config.data));
+ ret = -EINVAL;
goto bail;
}
/* Jump the CRC DWORD */