diff options
| author | Dmitry Torokhov <dmitry.torokhov@gmail.com> | 2024-09-04 21:17:19 -0700 |
|---|---|---|
| committer | Dmitry Torokhov <dmitry.torokhov@gmail.com> | 2024-10-04 00:58:16 -0700 |
| commit | 31b6b9a46d0af9c1ec7133e41302b3ef76016b04 (patch) | |
| tree | 5d9224aa361bfba014228e70ea10d76356b04455 /drivers/input/serio | |
| parent | 7dc406b736b9acf01379d2235d97bb4873b504e7 (diff) | |
| download | linux-31b6b9a46d0af9c1ec7133e41302b3ef76016b04.tar.gz linux-31b6b9a46d0af9c1ec7133e41302b3ef76016b04.tar.bz2 linux-31b6b9a46d0af9c1ec7133e41302b3ef76016b04.zip | |
Input: ps2-gpio - use guard notation when acquiring mutex
Using guard notation makes the code more compact and error handling
more robust by ensuring that mutexes are released in all code paths
when control leaves critical section.
Link: https://lore.kernel.org/r/20240905041732.2034348-15-dmitry.torokhov@gmail.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Diffstat (limited to 'drivers/input/serio')
| -rw-r--r-- | drivers/input/serio/ps2-gpio.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/input/serio/ps2-gpio.c b/drivers/input/serio/ps2-gpio.c index 3a431395c464..3e4ae2cc6552 100644 --- a/drivers/input/serio/ps2-gpio.c +++ b/drivers/input/serio/ps2-gpio.c @@ -133,12 +133,12 @@ static int ps2_gpio_write(struct serio *serio, unsigned char val) int ret = 0; if (in_task()) { - mutex_lock(&drvdata->tx.mutex); + guard(mutex)(&drvdata->tx.mutex); + __ps2_gpio_write(serio, val); if (!wait_for_completion_timeout(&drvdata->tx.complete, msecs_to_jiffies(10000))) ret = SERIO_TIMEOUT; - mutex_unlock(&drvdata->tx.mutex); } else { __ps2_gpio_write(serio, val); } |