summaryrefslogtreecommitdiff
path: root/drivers/iommu
diff options
context:
space:
mode:
authorSean Christopherson <seanjc@google.com>2025-04-04 12:38:20 -0700
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2025-05-02 07:50:45 +0200
commit415f3481ca764318099f05c2c8edefe070922a95 (patch)
treecb9a1e0ffeae46c37a95cbe30fffbfd271388759 /drivers/iommu
parent1d7c4b2b0bbfb09b55b2dc0e2355d7936bf89381 (diff)
downloadlinux-415f3481ca764318099f05c2c8edefe070922a95.tar.gz
linux-415f3481ca764318099f05c2c8edefe070922a95.tar.bz2
linux-415f3481ca764318099f05c2c8edefe070922a95.zip
iommu/amd: Return an error if vCPU affinity is set for non-vCPU IRTE
[ Upstream commit 07172206a26dcf3f0bf7c3ecaadd4242b008ea54 ] Return -EINVAL instead of success if amd_ir_set_vcpu_affinity() is invoked without use_vapic; lying to KVM about whether or not the IRTE was configured to post IRQs is all kinds of bad. Fixes: d98de49a53e4 ("iommu/amd: Enable vAPIC interrupt remapping mode by default") Signed-off-by: Sean Christopherson <seanjc@google.com> Message-ID: <20250404193923.1413163-6-seanjc@google.com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/iommu')
-rw-r--r--drivers/iommu/amd/iommu.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/iommu/amd/iommu.c b/drivers/iommu/amd/iommu.c
index 95bd7c25ba6f..83c5d786686d 100644
--- a/drivers/iommu/amd/iommu.c
+++ b/drivers/iommu/amd/iommu.c
@@ -3619,7 +3619,7 @@ static int amd_ir_set_vcpu_affinity(struct irq_data *data, void *vcpu_info)
* we should not modify the IRTE
*/
if (!dev_data || !dev_data->use_vapic)
- return 0;
+ return -EINVAL;
ir_data->cfg = irqd_cfg(data);
pi_data->ir_data = ir_data;