diff options
| author | Pan Bian <bianpan2016@163.com> | 2021-01-20 23:22:02 -0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-01-27 11:47:53 +0100 |
| commit | 49aaf012c4785f8f33ab0ca7dcf2560915d0f5ca (patch) | |
| tree | a6dabacd8f063e81eb2a077e9dfc382b6aed24ad /drivers/lightnvm | |
| parent | 0ff55fc4d6a1155607c3da8fb36eadb3a93fdb3c (diff) | |
| download | linux-49aaf012c4785f8f33ab0ca7dcf2560915d0f5ca.tar.gz linux-49aaf012c4785f8f33ab0ca7dcf2560915d0f5ca.tar.bz2 linux-49aaf012c4785f8f33ab0ca7dcf2560915d0f5ca.zip | |
lightnvm: fix memory leak when submit fails
commit 97784481757fba7570121a70dd37ca74a29f50a8 upstream.
The allocated page is not released if error occurs in
nvm_submit_io_sync_raw(). __free_page() is moved ealier to avoid
possible memory leak issue.
Fixes: aff3fb18f957 ("lightnvm: move bad block and chunk state logic to core")
Signed-off-by: Pan Bian <bianpan2016@163.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/lightnvm')
| -rw-r--r-- | drivers/lightnvm/core.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/lightnvm/core.c b/drivers/lightnvm/core.c index a2ebc75af8c7..4714aa936b2a 100644 --- a/drivers/lightnvm/core.c +++ b/drivers/lightnvm/core.c @@ -849,11 +849,10 @@ static int nvm_bb_chunk_sense(struct nvm_dev *dev, struct ppa_addr ppa) rqd.ppa_addr = generic_to_dev_addr(dev, ppa); ret = nvm_submit_io_sync_raw(dev, &rqd); + __free_page(page); if (ret) return ret; - __free_page(page); - return rqd.error; } |