summaryrefslogtreecommitdiff
path: root/drivers/media
diff options
context:
space:
mode:
authorHao Yao <hao.yao@intel.com>2025-04-25 12:33:25 +0800
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2025-11-13 15:37:17 -0500
commit5f4cfb4b99b10c45a605b648b9c97663e6b2d100 (patch)
treed5bb46189938a156503b7eaa708fb4232175605c /drivers/media
parentbd8d046c601c6f220be799c8d111e519a9e9a12d (diff)
downloadlinux-5f4cfb4b99b10c45a605b648b9c97663e6b2d100.tar.gz
linux-5f4cfb4b99b10c45a605b648b9c97663e6b2d100.tar.bz2
linux-5f4cfb4b99b10c45a605b648b9c97663e6b2d100.zip
media: ov08x40: Fix the horizontal flip control
[ Upstream commit c7df6f339af94689fdc433887f9fbb480bf8a4ed ] The datasheet of ov08x40 doesn't match the hardware behavior. 0x3821[2] == 1 is the original state and 0 the horizontal flip enabled. Signed-off-by: Hao Yao <hao.yao@intel.com> Reviewed-by: Hans de Goede <hansg@kernel.org> Tested-by: Hans de Goede <hansg@kernel.org> # ThinkPad X1 Carbon Gen 12 & Gen 13 Reviewed-by: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/media')
-rw-r--r--drivers/media/i2c/ov08x40.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/media/i2c/ov08x40.c b/drivers/media/i2c/ov08x40.c
index e0094305ca2a..90887fc54fb0 100644
--- a/drivers/media/i2c/ov08x40.c
+++ b/drivers/media/i2c/ov08x40.c
@@ -1648,7 +1648,7 @@ static int ov08x40_set_ctrl_hflip(struct ov08x40 *ov08x, u32 ctrl_val)
return ov08x40_write_reg(ov08x, OV08X40_REG_MIRROR,
OV08X40_REG_VALUE_08BIT,
- ctrl_val ? val | BIT(2) : val & ~BIT(2));
+ ctrl_val ? val & ~BIT(2) : val | BIT(2));
}
static int ov08x40_set_ctrl_vflip(struct ov08x40 *ov08x, u32 ctrl_val)