diff options
| author | Johan Hovold <johan@kernel.org> | 2021-12-22 11:48:43 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2022-01-27 09:19:28 +0100 |
| commit | 3cead5b7a88c99340b087659127fa4cc1b10c9b3 (patch) | |
| tree | f394d04d56aa9970e90015af8b9020518198136a /drivers/net | |
| parent | 38e28033a56b5ea4afb2481cf0f8abb145d5774b (diff) | |
| download | linux-3cead5b7a88c99340b087659127fa4cc1b10c9b3.tar.gz linux-3cead5b7a88c99340b087659127fa4cc1b10c9b3.tar.bz2 linux-3cead5b7a88c99340b087659127fa4cc1b10c9b3.zip | |
can: softing_cs: softingcs_probe(): fix memleak on registration failure
commit ced4913efb0acc844ed65cc01d091a85d83a2082 upstream.
In case device registration fails during probe, the driver state and
the embedded platform device structure needs to be freed using
platform_device_put() to properly free all resources (e.g. the device
name).
Fixes: 0a0b7a5f7a04 ("can: add driver for Softing card")
Link: https://lore.kernel.org/all/20211222104843.6105-1-johan@kernel.org
Cc: stable@vger.kernel.org # 2.6.38
Signed-off-by: Johan Hovold <johan@kernel.org>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/net')
| -rw-r--r-- | drivers/net/can/softing/softing_cs.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/can/softing/softing_cs.c b/drivers/net/can/softing/softing_cs.c index 2e93ee792373..e5c939b63fa6 100644 --- a/drivers/net/can/softing/softing_cs.c +++ b/drivers/net/can/softing/softing_cs.c @@ -293,7 +293,7 @@ static int softingcs_probe(struct pcmcia_device *pcmcia) return 0; platform_failed: - kfree(dev); + platform_device_put(pdev); mem_failed: pcmcia_bad: pcmcia_failed: |