diff options
| author | Yang Li <yang.lee@linux.alibaba.com> | 2021-06-07 16:40:36 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-09-22 12:26:44 +0200 |
| commit | 4a6c7c818bcb8c18c2fc77b37a2d0b2cfa14d7d9 (patch) | |
| tree | 8a0679c8a7d881d9fc3a46be9c859796f40b459f /drivers/ntb | |
| parent | 5a161419496352e91b30a1915684c1d644ed8a2e (diff) | |
| download | linux-4a6c7c818bcb8c18c2fc77b37a2d0b2cfa14d7d9.tar.gz linux-4a6c7c818bcb8c18c2fc77b37a2d0b2cfa14d7d9.tar.bz2 linux-4a6c7c818bcb8c18c2fc77b37a2d0b2cfa14d7d9.zip | |
NTB: perf: Fix an error code in perf_setup_inbuf()
[ Upstream commit 0097ae5f7af5684f961a5f803ff7ad3e6f933668 ]
When the function IS_ALIGNED() returns false, the value of ret is 0.
So, we set ret to -EINVAL to indicate this error.
Clean up smatch warning:
drivers/ntb/test/ntb_perf.c:602 perf_setup_inbuf() warn: missing error
code 'ret'.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Reviewed-by: Serge Semin <fancer.lancer@gmail.com>
Signed-off-by: Jon Mason <jdmason@kudzu.us>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/ntb')
| -rw-r--r-- | drivers/ntb/test/ntb_perf.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/ntb/test/ntb_perf.c b/drivers/ntb/test/ntb_perf.c index 5ce4766a6c9e..251fe75798c1 100644 --- a/drivers/ntb/test/ntb_perf.c +++ b/drivers/ntb/test/ntb_perf.c @@ -597,6 +597,7 @@ static int perf_setup_inbuf(struct perf_peer *peer) return -ENOMEM; } if (!IS_ALIGNED(peer->inbuf_xlat, xlat_align)) { + ret = -EINVAL; dev_err(&perf->ntb->dev, "Unaligned inbuf allocated\n"); goto err_free_inbuf; } |