diff options
| author | Philip Chen <philipchen@chromium.org> | 2024-08-26 21:53:13 +0000 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2024-10-17 15:24:20 +0200 |
| commit | b01793cc63dd39c8f12b9a3d8dc115fbebb19e2a (patch) | |
| tree | 08d25b4f2a2a3595371b3cd0e21f12c9941c36a9 /drivers/nvdimm | |
| parent | 784744b01b0800e4ef86aa00d90004fe36043504 (diff) | |
| download | linux-b01793cc63dd39c8f12b9a3d8dc115fbebb19e2a.tar.gz linux-b01793cc63dd39c8f12b9a3d8dc115fbebb19e2a.tar.bz2 linux-b01793cc63dd39c8f12b9a3d8dc115fbebb19e2a.zip | |
virtio_pmem: Check device status before requesting flush
[ Upstream commit e25fbcd97cf52c3c9824d44b5c56c19673c3dd50 ]
If a pmem device is in a bad status, the driver side could wait for
host ack forever in virtio_pmem_flush(), causing the system to hang.
So add a status check in the beginning of virtio_pmem_flush() to return
early if the device is not activated.
Signed-off-by: Philip Chen <philipchen@chromium.org>
Message-Id: <20240826215313.2673566-1-philipchen@chromium.org>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Acked-by: Pankaj Gupta <pankaj.gupta.linux@gmail.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/nvdimm')
| -rw-r--r-- | drivers/nvdimm/nd_virtio.c | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/drivers/nvdimm/nd_virtio.c b/drivers/nvdimm/nd_virtio.c index 1f8c667c6f1e..839f10ca56ea 100644 --- a/drivers/nvdimm/nd_virtio.c +++ b/drivers/nvdimm/nd_virtio.c @@ -44,6 +44,15 @@ static int virtio_pmem_flush(struct nd_region *nd_region) unsigned long flags; int err, err1; + /* + * Don't bother to submit the request to the device if the device is + * not activated. + */ + if (vdev->config->get_status(vdev) & VIRTIO_CONFIG_S_NEEDS_RESET) { + dev_info(&vdev->dev, "virtio pmem device needs a reset\n"); + return -EIO; + } + might_sleep(); req_data = kmalloc(sizeof(*req_data), GFP_KERNEL); if (!req_data) |