summaryrefslogtreecommitdiff
path: root/drivers/platform
diff options
context:
space:
mode:
authorQinglang Miao <miaoqinglang@huawei.com>2020-11-25 14:50:32 +0800
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2020-12-30 11:51:15 +0100
commitf4935d3c7b57cee3ed73aa20417d240c2b43f40f (patch)
tree1467f01ee390e04abb9aa3ecd028a5303757043d /drivers/platform
parent3d64e8ce592bdc6ab2663b3a5ba4032047b27f41 (diff)
downloadlinux-f4935d3c7b57cee3ed73aa20417d240c2b43f40f.tar.gz
linux-f4935d3c7b57cee3ed73aa20417d240c2b43f40f.tar.bz2
linux-f4935d3c7b57cee3ed73aa20417d240c2b43f40f.zip
platform/x86: dell-smbios-base: Fix error return code in dell_smbios_init
[ Upstream commit 2425ccd30fd78ce35237350fe8baac31dc18bd45 ] Fix to return the error code -ENODEV when fails to init wmi and smm. Fixes: 41e36f2f85af ("platform/x86: dell-smbios: Link all dell-smbios-* modules together") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com> Reviewed-by: Mario Limonciello <mario.limonciello@dell.com> Link: https://lore.kernel.org/r/20201125065032.154125-1-miaoqinglang@huawei.com Signed-off-by: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/platform')
-rw-r--r--drivers/platform/x86/dell-smbios-base.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/platform/x86/dell-smbios-base.c b/drivers/platform/x86/dell-smbios-base.c
index fe59b0ebff31..ceb8e701028d 100644
--- a/drivers/platform/x86/dell-smbios-base.c
+++ b/drivers/platform/x86/dell-smbios-base.c
@@ -594,6 +594,7 @@ static int __init dell_smbios_init(void)
if (wmi && smm) {
pr_err("No SMBIOS backends available (wmi: %d, smm: %d)\n",
wmi, smm);
+ ret = -ENODEV;
goto fail_create_group;
}