diff options
| author | Philipp Zabel <p.zabel@pengutronix.de> | 2021-06-07 10:26:15 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-07-20 16:10:52 +0200 |
| commit | 8ef43fa4646fc69034340cdcae2b0033cb06b4ea (patch) | |
| tree | ad2481e6b8eebb182466d3dfe8102d02376bf671 /drivers/reset | |
| parent | 04bb5b3ea08d2dabd8f454be9650429af490535e (diff) | |
| download | linux-8ef43fa4646fc69034340cdcae2b0033cb06b4ea.tar.gz linux-8ef43fa4646fc69034340cdcae2b0033cb06b4ea.tar.bz2 linux-8ef43fa4646fc69034340cdcae2b0033cb06b4ea.zip | |
reset: bail if try_module_get() fails
[ Upstream commit 4fb26fb83f0def3d39c14e268bcd4003aae8fade ]
Abort instead of returning a new reset control for a reset controller
device that is going to have its module unloaded.
Reported-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Fixes: 61fc41317666 ("reset: Add reset controller API")
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20210607082615.15160-1-p.zabel@pengutronix.de
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/reset')
| -rw-r--r-- | drivers/reset/core.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/reset/core.c b/drivers/reset/core.c index 76c0dc7f165d..688b4f6227fc 100644 --- a/drivers/reset/core.c +++ b/drivers/reset/core.c @@ -565,7 +565,10 @@ static struct reset_control *__reset_control_get_internal( if (!rstc) return ERR_PTR(-ENOMEM); - try_module_get(rcdev->owner); + if (!try_module_get(rcdev->owner)) { + kfree(rstc); + return ERR_PTR(-ENODEV); + } rstc->rcdev = rcdev; list_add(&rstc->list, &rcdev->reset_control_head); |