diff options
| author | Brian Masney <bmasney@redhat.com> | 2025-07-10 11:20:21 -0400 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2025-08-15 12:05:06 +0200 |
| commit | 226c69544beae1dabfe38b804b201220c7aa7c01 (patch) | |
| tree | 150a7ea902cc2225a584aa7ac58859d0f3de8337 /drivers/rtc | |
| parent | 85eaa246efd5988c0d178f409cbc909c6f7d98da (diff) | |
| download | linux-226c69544beae1dabfe38b804b201220c7aa7c01.tar.gz linux-226c69544beae1dabfe38b804b201220c7aa7c01.tar.bz2 linux-226c69544beae1dabfe38b804b201220c7aa7c01.zip | |
rtc: ds1307: fix incorrect maximum clock rate handling
[ Upstream commit cf6eb547a24af7ad7bbd2abe9c5327f956bbeae8 ]
When ds3231_clk_sqw_round_rate() is called with a requested rate higher
than the highest supported rate, it currently returns 0, which disables
the clock. According to the clk API, round_rate() should instead return
the highest supported rate. Update the function to return the maximum
supported rate in this case.
Fixes: 6c6ff145b3346 ("rtc: ds1307: add clock provider support for DS3231")
Signed-off-by: Brian Masney <bmasney@redhat.com>
Link: https://lore.kernel.org/r/20250710-rtc-clk-round-rate-v1-1-33140bb2278e@redhat.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/rtc')
| -rw-r--r-- | drivers/rtc/rtc-ds1307.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/rtc/rtc-ds1307.c b/drivers/rtc/rtc-ds1307.c index b7f8b3f9b059..73f2dd3af4d4 100644 --- a/drivers/rtc/rtc-ds1307.c +++ b/drivers/rtc/rtc-ds1307.c @@ -1461,7 +1461,7 @@ static long ds3231_clk_sqw_round_rate(struct clk_hw *hw, unsigned long rate, return ds3231_clk_sqw_rates[i]; } - return 0; + return ds3231_clk_sqw_rates[ARRAY_SIZE(ds3231_clk_sqw_rates) - 1]; } static int ds3231_clk_sqw_set_rate(struct clk_hw *hw, unsigned long rate, |