diff options
| author | Sumit Saxena <sumit.saxena@broadcom.com> | 2022-05-26 13:01:57 -0400 |
|---|---|---|
| committer | Martin K. Petersen <martin.petersen@oracle.com> | 2022-06-01 22:23:09 -0400 |
| commit | 4094981db7b6ed6ebe3ebe398d8d9136ac5c44c8 (patch) | |
| tree | 0c04943b310a439ce7d2ccc5db6bc06580555d34 /drivers/scsi/mpi3mr/mpi3mr.h | |
| parent | f9f0a46141e2e39bedb4779c88380d1b5f018c14 (diff) | |
| download | linux-4094981db7b6ed6ebe3ebe398d8d9136ac5c44c8.tar.gz linux-4094981db7b6ed6ebe3ebe398d8d9136ac5c44c8.tar.bz2 linux-4094981db7b6ed6ebe3ebe398d8d9136ac5c44c8.zip | |
scsi: mpi3mr: Rework mrioc->bsg_device model to fix warnings
During driver unload, mrioc->bsg_device reference count becomes
negative. Also, as reported in [1], the driver's bsg_device model had few
more bugs. Fix all these up.
[1] https://marc.info/?l=linux-scsi&m=165183971411991&w=2
Link: https://lore.kernel.org/r/20220526170157.58274-1-sumit.saxena@broadcom.com
Fixes: 4268fa751365 ("scsi: mpi3mr: Add bsg device support")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Tested-by: Tomas Henzl <thenzl@redhat.com>
Signed-off-by: Sumit Saxena <sumit.saxena@broadcom.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/scsi/mpi3mr/mpi3mr.h')
| -rw-r--r-- | drivers/scsi/mpi3mr/mpi3mr.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/scsi/mpi3mr/mpi3mr.h b/drivers/scsi/mpi3mr/mpi3mr.h index 01cd01787b0f..0e1cb4aa4ca2 100644 --- a/drivers/scsi/mpi3mr/mpi3mr.h +++ b/drivers/scsi/mpi3mr/mpi3mr.h @@ -954,7 +954,7 @@ struct mpi3mr_ioc { u16 active_poll_qcount; u16 requested_poll_qcount; - struct device *bsg_dev; + struct device bsg_dev; struct request_queue *bsg_queue; u8 stop_bsgs; u8 *logdata_buf; |