summaryrefslogtreecommitdiff
path: root/drivers/scsi
diff options
context:
space:
mode:
authorQianfeng Rong <rongqianfeng@vivo.com>2025-09-05 15:54:43 +0800
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2025-10-15 12:00:12 +0200
commit87c5ec3e3089e07b7fe56d58c342ac6c8b332839 (patch)
tree0183bb78f17117faa2a45682d55122b3d77ec0de /drivers/scsi
parent0846bce8f307ee0095203ff2e3606e5a724ea906 (diff)
downloadlinux-87c5ec3e3089e07b7fe56d58c342ac6c8b332839.tar.gz
linux-87c5ec3e3089e07b7fe56d58c342ac6c8b332839.tar.bz2
linux-87c5ec3e3089e07b7fe56d58c342ac6c8b332839.zip
scsi: qla2xxx: edif: Fix incorrect sign of error code
[ Upstream commit 066b8f3fa85c1be7fb7dbae202231e131d38f7bc ] Change the error code EAGAIN to -EAGAIN in qla24xx_sadb_update() and qla_edif_process_els() to align with qla2x00_start_sp() returning negative error codes or QLA_SUCCESS, preventing logical errors. Fixes: 0b3f3143d473 ("scsi: qla2xxx: edif: Add retry for ELS passthrough") Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com> Message-ID: <20250905075446.381139-2-rongqianfeng@vivo.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/scsi')
-rw-r--r--drivers/scsi/qla2xxx/qla_edif.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/scsi/qla2xxx/qla_edif.c b/drivers/scsi/qla2xxx/qla_edif.c
index dcde55c8ee5d..be20e2c457b8 100644
--- a/drivers/scsi/qla2xxx/qla_edif.c
+++ b/drivers/scsi/qla2xxx/qla_edif.c
@@ -1797,7 +1797,7 @@ retry:
switch (rval) {
case QLA_SUCCESS:
break;
- case EAGAIN:
+ case -EAGAIN:
msleep(EDIF_MSLEEP_INTERVAL);
cnt++;
if (cnt < EDIF_RETRY_COUNT)
@@ -3648,7 +3648,7 @@ retry:
p->e.extra_rx_xchg_address, p->e.extra_control_flags,
sp->handle, sp->remap.req.len, bsg_job);
break;
- case EAGAIN:
+ case -EAGAIN:
msleep(EDIF_MSLEEP_INTERVAL);
cnt++;
if (cnt < EDIF_RETRY_COUNT)