diff options
| author | Nitin Rawat <quic_nitirawa@quicinc.com> | 2025-05-26 21:08:12 +0530 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2025-06-19 15:28:35 +0200 |
| commit | 0fd2ae401720e238a96d6bbd5262982802e5c864 (patch) | |
| tree | d81673297f7164bb660807fdf5a8667ff3f957d9 /drivers/ufs | |
| parent | d2507aeea45b3c5aa24d5daae0cf3db76895c0b7 (diff) | |
| download | linux-0fd2ae401720e238a96d6bbd5262982802e5c864.tar.gz linux-0fd2ae401720e238a96d6bbd5262982802e5c864.tar.bz2 linux-0fd2ae401720e238a96d6bbd5262982802e5c864.zip | |
scsi: ufs: qcom: Prevent calling phy_exit() before phy_init()
[ Upstream commit 7831003165d37ecb7b33843fcee05cada0359a82 ]
Prevent calling phy_exit() before phy_init() to avoid abnormal power
count and the following warning during boot up.
[5.146763] phy phy-1d80000.phy.0: phy_power_on was called before phy_init
Fixes: 7bac65687510 ("scsi: ufs: qcom: Power off the PHY if it was already powered on in ufs_qcom_power_up_sequence()")
Signed-off-by: Nitin Rawat <quic_nitirawa@quicinc.com>
Link: https://lore.kernel.org/r/20250526153821.7918-2-quic_nitirawa@quicinc.com
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/ufs')
| -rw-r--r-- | drivers/ufs/host/ufs-qcom.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c index c6417ef074a4..c94824c999cc 100644 --- a/drivers/ufs/host/ufs-qcom.c +++ b/drivers/ufs/host/ufs-qcom.c @@ -453,10 +453,9 @@ static int ufs_qcom_power_up_sequence(struct ufs_hba *hba) dev_warn(hba->dev, "%s: host reset returned %d\n", __func__, ret); - if (phy->power_count) { + if (phy->power_count) phy_power_off(phy); - phy_exit(phy); - } + /* phy initialization - calibrate the phy */ ret = phy_init(phy); |