summaryrefslogtreecommitdiff
path: root/drivers/video
diff options
context:
space:
mode:
authorMarkus Elfring <elfring@users.sourceforge.net>2023-04-13 21:35:36 +0200
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2025-04-10 14:37:29 +0200
commit88ebc63d6a6758f0f483113f68da74de5d803a09 (patch)
tree388997cd2db45f19c7bbac1fabf753effce6c56e /drivers/video
parentf6c1a08e91630f4a9137c3ff332b4c460add92c4 (diff)
downloadlinux-88ebc63d6a6758f0f483113f68da74de5d803a09.tar.gz
linux-88ebc63d6a6758f0f483113f68da74de5d803a09.tar.bz2
linux-88ebc63d6a6758f0f483113f68da74de5d803a09.zip
fbdev: au1100fb: Move a variable assignment behind a null pointer check
[ Upstream commit 2df2c0caaecfd869b49e14f2b8df822397c5dd7f ] The address of a data structure member was determined before a corresponding null pointer check in the implementation of the function “au1100fb_setmode”. This issue was detected by using the Coccinelle software. Fixes: 3b495f2bb749 ("Au1100 FB driver uplift for 2.6.") Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Acked-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com> Signed-off-by: Helge Deller <deller@gmx.de> Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/video')
-rw-r--r--drivers/video/fbdev/au1100fb.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/video/fbdev/au1100fb.c b/drivers/video/fbdev/au1100fb.c
index 648d6cac86e8..682258968079 100644
--- a/drivers/video/fbdev/au1100fb.c
+++ b/drivers/video/fbdev/au1100fb.c
@@ -137,13 +137,15 @@ static int au1100fb_fb_blank(int blank_mode, struct fb_info *fbi)
*/
int au1100fb_setmode(struct au1100fb_device *fbdev)
{
- struct fb_info *info = &fbdev->info;
+ struct fb_info *info;
u32 words;
int index;
if (!fbdev)
return -EINVAL;
+ info = &fbdev->info;
+
/* Update var-dependent FB info */
if (panel_is_active(fbdev->panel) || panel_is_color(fbdev->panel)) {
if (info->var.bits_per_pixel <= 8) {