summaryrefslogtreecommitdiff
path: root/drivers/watchdog
diff options
context:
space:
mode:
authorNick Chan <towinchenmi@gmail.com>2024-10-02 00:59:51 +0800
committerWim Van Sebroeck <wim@linux-watchdog.org>2024-11-04 13:13:02 +0100
commit51dfe714c03c066aabc815a2bb2adcc998dfcb30 (patch)
treee7de90659e0d426e2af5391519545c1a160374c2 /drivers/watchdog
parent3ab1663af6c1ac7d4bd1fb1371a4972bac2922a4 (diff)
downloadlinux-51dfe714c03c066aabc815a2bb2adcc998dfcb30.tar.gz
linux-51dfe714c03c066aabc815a2bb2adcc998dfcb30.tar.bz2
linux-51dfe714c03c066aabc815a2bb2adcc998dfcb30.zip
watchdog: apple: Actually flush writes after requesting watchdog restart
Although there is an existing code comment about flushing the writes, writes were not actually being flushed. Actually flush the writes by changing readl_relaxed() to readl(). Fixes: 4ed224aeaf661 ("watchdog: Add Apple SoC watchdog driver") Suggested-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Nick Chan <towinchenmi@gmail.com> Reviewed-by: Guenter Roeck <linux@roeck-us.net> Link: https://lore.kernel.org/r/20241001170018.20139-2-towinchenmi@gmail.com Signed-off-by: Guenter Roeck <linux@roeck-us.net> Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
Diffstat (limited to 'drivers/watchdog')
-rw-r--r--drivers/watchdog/apple_wdt.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/watchdog/apple_wdt.c b/drivers/watchdog/apple_wdt.c
index d4f739932f0b..62dabf223d90 100644
--- a/drivers/watchdog/apple_wdt.c
+++ b/drivers/watchdog/apple_wdt.c
@@ -130,7 +130,7 @@ static int apple_wdt_restart(struct watchdog_device *wdd, unsigned long mode,
* can take up to ~20-25ms until the SoC is actually reset. Just wait
* 50ms here to be safe.
*/
- (void)readl_relaxed(wdt->regs + APPLE_WDT_WD1_CUR_TIME);
+ (void)readl(wdt->regs + APPLE_WDT_WD1_CUR_TIME);
mdelay(50);
return 0;