summaryrefslogtreecommitdiff
path: root/drivers
diff options
context:
space:
mode:
authorTaehee Yoo <ap420073@gmail.com>2019-07-15 14:10:17 +0900
committerBen Hutchings <ben@decadent.org.uk>2019-10-31 22:15:04 +0000
commit7c711c927a6a0db6b992c9b1a35981e7f361cdf5 (patch)
tree50e00ddcaed9473c3aa70496cd277b1ce05a8af4 /drivers
parentb33b7003f4a40c15cec238eaa62ba0829d8d5269 (diff)
downloadlinux-7c711c927a6a0db6b992c9b1a35981e7f361cdf5.tar.gz
linux-7c711c927a6a0db6b992c9b1a35981e7f361cdf5.tar.bz2
linux-7c711c927a6a0db6b992c9b1a35981e7f361cdf5.zip
caif-hsi: fix possible deadlock in cfhsi_exit_module()
commit fdd258d49e88a9e0b49ef04a506a796f1c768a8e upstream. cfhsi_exit_module() calls unregister_netdev() under rtnl_lock(). but unregister_netdev() internally calls rtnl_lock(). So deadlock would occur. Fixes: c41254006377 ("caif-hsi: Add rtnl support") Signed-off-by: Taehee Yoo <ap420073@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/net/caif/caif_hsi.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/caif/caif_hsi.c b/drivers/net/caif/caif_hsi.c
index b3b922adc0e4..e10834ca88b2 100644
--- a/drivers/net/caif/caif_hsi.c
+++ b/drivers/net/caif/caif_hsi.c
@@ -1467,7 +1467,7 @@ static void __exit cfhsi_exit_module(void)
rtnl_lock();
list_for_each_safe(list_node, n, &cfhsi_list) {
cfhsi = list_entry(list_node, struct cfhsi, list);
- unregister_netdev(cfhsi->ndev);
+ unregister_netdevice(cfhsi->ndev);
}
rtnl_unlock();
}