diff options
| author | Nathan Sullivan <nathan.sullivan@ni.com> | 2017-03-22 15:27:01 -0500 |
|---|---|---|
| committer | Ben Hutchings <ben@decadent.org.uk> | 2017-07-18 18:38:37 +0100 |
| commit | 80d872be3712786a924c804ff8b9aa3938b697ea (patch) | |
| tree | a4a0a1fb164c064e14c8d4f8f933bf44a6451ae3 /drivers | |
| parent | df7a2d0af9f7ab73cf22a7b62bbc0bad93a02110 (diff) | |
| download | linux-80d872be3712786a924c804ff8b9aa3938b697ea.tar.gz linux-80d872be3712786a924c804ff8b9aa3938b697ea.tar.bz2 linux-80d872be3712786a924c804ff8b9aa3938b697ea.zip | |
net: phy: handle state correctly in phy_stop_machine
commit 49d52e8108a21749dc2114b924c907db43358984 upstream.
If the PHY is halted on stop, then do not set the state to PHY_UP. This
ensures the phy will be restarted later in phy_start when the machine is
started again.
Fixes: 00db8189d984 ("This patch adds a PHY Abstraction Layer to the Linux Kernel, enabling ethernet drivers to remain as ignorant as is reasonable of the connected PHY's design and operation details.")
Signed-off-by: Nathan Sullivan <nathan.sullivan@ni.com>
Signed-off-by: Brad Mouring <brad.mouring@ni.com>
Acked-by: Xander Huff <xander.huff@ni.com>
Acked-by: Kyle Roeschley <kyle.roeschley@ni.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/net/phy/phy.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c index 3cbda0851f83..f3eb42789c4c 100644 --- a/drivers/net/phy/phy.c +++ b/drivers/net/phy/phy.c @@ -453,7 +453,7 @@ void phy_stop_machine(struct phy_device *phydev) cancel_delayed_work_sync(&phydev->state_queue); mutex_lock(&phydev->lock); - if (phydev->state > PHY_UP) + if (phydev->state > PHY_UP && phydev->state != PHY_HALTED) phydev->state = PHY_UP; mutex_unlock(&phydev->lock); |