diff options
| author | Qiushi Wu <wu000273@umn.edu> | 2020-05-27 16:00:19 -0500 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2020-06-03 08:19:41 +0200 |
| commit | 0dc3cd0981c78d0b1669104aa9d28e3c3ce5460c (patch) | |
| tree | 644e5f215d0d84897e6f6c31cca617b7c8716a26 /drivers | |
| parent | 51b779592f63242a603c308190f273c678fcfe81 (diff) | |
| download | linux-0dc3cd0981c78d0b1669104aa9d28e3c3ce5460c.tar.gz linux-0dc3cd0981c78d0b1669104aa9d28e3c3ce5460c.tar.bz2 linux-0dc3cd0981c78d0b1669104aa9d28e3c3ce5460c.zip | |
iommu: Fix reference count leak in iommu_group_alloc.
[ Upstream commit 7cc31613734c4870ae32f5265d576ef296621343 ]
kobject_init_and_add() takes reference even when it fails.
Thus, when kobject_init_and_add() returns an error,
kobject_put() must be called to properly clean up the kobject.
Fixes: d72e31c93746 ("iommu: IOMMU Groups")
Signed-off-by: Qiushi Wu <wu000273@umn.edu>
Link: https://lore.kernel.org/r/20200527210020.6522-1-wu000273@umn.edu
Signed-off-by: Joerg Roedel <jroedel@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/iommu/iommu.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c index 00e1c908cd8e..85ef6c9bc898 100644 --- a/drivers/iommu/iommu.c +++ b/drivers/iommu/iommu.c @@ -392,7 +392,7 @@ struct iommu_group *iommu_group_alloc(void) NULL, "%d", group->id); if (ret) { ida_simple_remove(&iommu_group_ida, group->id); - kfree(group); + kobject_put(&group->kobj); return ERR_PTR(ret); } |