diff options
| author | Lv Ruyi <lv.ruyi@zte.com.cn> | 2022-04-24 03:14:30 +0000 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2022-05-12 12:14:55 +0200 |
| commit | bc03249a5d2dab1e9def59c9f0be7053998e71d7 (patch) | |
| tree | 17f1c09390c4f9cbdc4d3959216bdb11c231d5dc /drivers | |
| parent | 953345b8375b5a4f85f9fe210b652027d23177a4 (diff) | |
| download | linux-bc03249a5d2dab1e9def59c9f0be7053998e71d7.tar.gz linux-bc03249a5d2dab1e9def59c9f0be7053998e71d7.tar.bz2 linux-bc03249a5d2dab1e9def59c9f0be7053998e71d7.zip | |
pinctrl: pistachio: fix use of irq_of_parse_and_map()
[ Upstream commit 0c9843a74a85224a89daa81fa66891dae2f930e1 ]
The irq_of_parse_and_map() function returns 0 on failure, and does not
return an negative value.
Fixes: cefc03e5995e ("pinctrl: Add Pistachio SoC pin control driver")
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
Link: https://lore.kernel.org/r/20220424031430.3170759-1-lv.ruyi@zte.com.cn
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/pinctrl/pinctrl-pistachio.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/pinctrl/pinctrl-pistachio.c b/drivers/pinctrl/pinctrl-pistachio.c index b2b7e238bda9..fc8c57527fb7 100644 --- a/drivers/pinctrl/pinctrl-pistachio.c +++ b/drivers/pinctrl/pinctrl-pistachio.c @@ -1374,10 +1374,10 @@ static int pistachio_gpio_register(struct pistachio_pinctrl *pctl) } irq = irq_of_parse_and_map(child, 0); - if (irq < 0) { - dev_err(pctl->dev, "No IRQ for bank %u: %d\n", i, irq); + if (!irq) { + dev_err(pctl->dev, "No IRQ for bank %u\n", i); of_node_put(child); - ret = irq; + ret = -EINVAL; goto err; } |