summaryrefslogtreecommitdiff
path: root/drivers
diff options
context:
space:
mode:
authorDave Jiang <dave.jiang@intel.com>2022-04-11 15:08:55 -0700
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2022-04-27 13:53:51 +0200
commit9a3c026dc3a59fa23c63d90752f07538a3c75646 (patch)
treec48a1fdeac7eab5b26ae6e89f8043baad373dde0 /drivers
parentf593f49fcd174ebe0ebeebecf46fadc134593ddb (diff)
downloadlinux-9a3c026dc3a59fa23c63d90752f07538a3c75646.tar.gz
linux-9a3c026dc3a59fa23c63d90752f07538a3c75646.tar.bz2
linux-9a3c026dc3a59fa23c63d90752f07538a3c75646.zip
dmaengine: idxd: add RO check for wq max_batch_size write
[ Upstream commit 66903461ffed0b66fc3e0200082d4e09365aacdc ] Block wq_max_batch_size_store() when the device is configured as read-only and not configurable. Fixes: e7184b159dd3 ("dmaengine: idxd: add support for configurable max wq batch size") Reported-by: Bernice Zhang <bernice.zhang@intel.com> Tested-by: Bernice Zhang <bernice.zhang@intel.com> Signed-off-by: Dave Jiang <dave.jiang@intel.com> Link: https://lore.kernel.org/r/164971493551.2201159.1942042593642155209.stgit@djiang5-desk3.ch.intel.com Signed-off-by: Vinod Koul <vkoul@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/dma/idxd/sysfs.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/dma/idxd/sysfs.c b/drivers/dma/idxd/sysfs.c
index 7b41cdff1a2c..5bf4b4be64e4 100644
--- a/drivers/dma/idxd/sysfs.c
+++ b/drivers/dma/idxd/sysfs.c
@@ -1132,6 +1132,9 @@ static ssize_t wq_max_batch_size_store(struct device *dev, struct device_attribu
u64 batch_size;
int rc;
+ if (!test_bit(IDXD_FLAG_CONFIGURABLE, &idxd->flags))
+ return -EPERM;
+
if (wq->state != IDXD_WQ_DISABLED)
return -EPERM;