diff options
| author | Daniel Vetter <daniel.vetter@ffwll.ch> | 2020-10-28 12:31:20 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-03-24 11:54:10 +0100 |
| commit | 7d09e9725b5dcc8d14e101de931e4969d033a6ad (patch) | |
| tree | 89dda81f92c82e6f411e29a29b5a9ae107fe1baa /drivers | |
| parent | 2ab0064c69251e8b78dd7b6abcc55ee6e3c1931f (diff) | |
| download | linux-7d09e9725b5dcc8d14e101de931e4969d033a6ad.tar.gz linux-7d09e9725b5dcc8d14e101de931e4969d033a6ad.tar.bz2 linux-7d09e9725b5dcc8d14e101de931e4969d033a6ad.zip | |
drm/ttm: Warn on pinning without holding a reference
[ Upstream commit 57fcd550eb15bce14a7154736379dfd4ed60ae81 ]
Not technically a problem for ttm, but very likely a driver bug and
pretty big time confusing for reviewing code.
So warn about it, both at cleanup time (so we catch these for sure)
and at pin/unpin time (so we know who's the culprit).
Reviewed-by: Huang Rui <ray.huang@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Cc: Christian Koenig <christian.koenig@amd.com>
Cc: Huang Rui <ray.huang@amd.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20201028113120.3641237-1-daniel.vetter@ffwll.ch
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/gpu/drm/ttm/ttm_bo.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index 22073e77fdf9..a76eb2c14e8c 100644 --- a/drivers/gpu/drm/ttm/ttm_bo.c +++ b/drivers/gpu/drm/ttm/ttm_bo.c @@ -514,7 +514,7 @@ static void ttm_bo_release(struct kref *kref) * shrinkers, now that they are queued for * destruction. */ - if (bo->pin_count) { + if (WARN_ON(bo->pin_count)) { bo->pin_count = 0; ttm_bo_del_from_lru(bo); ttm_bo_add_mem_to_lru(bo, &bo->mem); |