diff options
| author | Mario Limonciello <mario.limonciello@amd.com> | 2021-12-10 08:35:29 -0600 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-12-29 12:28:54 +0100 |
| commit | a42c41be8324a34b37c1e8eb81c469cab85e1fc8 (patch) | |
| tree | 6416bccfb2e31dbd2598ceb9d97017bec879d220 /drivers | |
| parent | 9ede07c4af14a72f452f0cefc7efec7af76d04c8 (diff) | |
| download | linux-a42c41be8324a34b37c1e8eb81c469cab85e1fc8.tar.gz linux-a42c41be8324a34b37c1e8eb81c469cab85e1fc8.tar.bz2 linux-a42c41be8324a34b37c1e8eb81c469cab85e1fc8.zip | |
platform/x86: amd-pmc: only use callbacks for suspend
commit 09fc14061f3ed28899c23b8714c066946fdbd43e upstream.
This driver is intended to be used exclusively for suspend to idle
so callbacks to send OS_HINT during hibernate and S5 will set OS_HINT
at the wrong time leading to an undefined behavior.
Cc: stable@vger.kernel.org
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
Link: https://lore.kernel.org/r/20211210143529.10594-1-mario.limonciello@amd.com
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/platform/x86/amd-pmc.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/platform/x86/amd-pmc.c b/drivers/platform/x86/amd-pmc.c index 54b88bedecdf..d3efd514614c 100644 --- a/drivers/platform/x86/amd-pmc.c +++ b/drivers/platform/x86/amd-pmc.c @@ -375,7 +375,8 @@ static int __maybe_unused amd_pmc_resume(struct device *dev) } static const struct dev_pm_ops amd_pmc_pm_ops = { - SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(amd_pmc_suspend, amd_pmc_resume) + .suspend_noirq = amd_pmc_suspend, + .resume_noirq = amd_pmc_resume, }; static const struct pci_device_id pmc_pci_ids[] = { |