diff options
| author | Ruan Jinjie <ruanjinjie@huawei.com> | 2023-08-18 13:12:21 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2023-08-30 16:11:02 +0200 |
| commit | afc9d3d217939842ba4e2795356b8dd53f7a2ed6 (patch) | |
| tree | 01462478edaae7fa2035629d434821cb29e6bbe9 /drivers | |
| parent | 029e491b8c11859525a1d6a307622bbc3a4ae559 (diff) | |
| download | linux-afc9d3d217939842ba4e2795356b8dd53f7a2ed6.tar.gz linux-afc9d3d217939842ba4e2795356b8dd53f7a2ed6.tar.bz2 linux-afc9d3d217939842ba4e2795356b8dd53f7a2ed6.zip | |
net: bcmgenet: Fix return value check for fixed_phy_register()
[ Upstream commit 32bbe64a1386065ab2aef8ce8cae7c689d0add6e ]
The fixed_phy_register() function returns error pointers and never
returns NULL. Update the checks accordingly.
Fixes: b0ba512e25d7 ("net: bcmgenet: enable driver to work without a device tree")
Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Acked-by: Doug Berger <opendmb@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/net/ethernet/broadcom/genet/bcmmii.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/broadcom/genet/bcmmii.c b/drivers/net/ethernet/broadcom/genet/bcmmii.c index 1fe8038587ac..1779ee524dac 100644 --- a/drivers/net/ethernet/broadcom/genet/bcmmii.c +++ b/drivers/net/ethernet/broadcom/genet/bcmmii.c @@ -608,7 +608,7 @@ static int bcmgenet_mii_pd_init(struct bcmgenet_priv *priv) }; phydev = fixed_phy_register(PHY_POLL, &fphy_status, NULL); - if (!phydev || IS_ERR(phydev)) { + if (IS_ERR(phydev)) { dev_err(kdev, "failed to register fixed PHY device\n"); return -ENODEV; } |