summaryrefslogtreecommitdiff
path: root/drivers
diff options
context:
space:
mode:
authorThomas Weißschuh <linux@weissschuh.net>2025-10-16 09:34:36 -0400
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2025-10-19 16:34:03 +0200
commitca0e8805d8f04bdc90f45854b83295f3031dd5a5 (patch)
tree0d8cfd2940a2797bbd47e736adb65d46b4bf93a4 /drivers
parent5187bb848aab42d43481d169cbcdb3d5df81c6a9 (diff)
downloadlinux-ca0e8805d8f04bdc90f45854b83295f3031dd5a5.tar.gz
linux-ca0e8805d8f04bdc90f45854b83295f3031dd5a5.tar.bz2
linux-ca0e8805d8f04bdc90f45854b83295f3031dd5a5.zip
ACPI: battery: initialize mutexes through devm_ APIs
[ Upstream commit 0710c1ce50455ed0db91bffa0eebbaa4f69b1773 ] Simplify the cleanup logic a bit. Signed-off-by: Thomas Weißschuh <linux@weissschuh.net> Link: https://patch.msgid.link/20240904-acpi-battery-cleanups-v1-3-a3bf74f22d40@weissschuh.net Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Stable-dep-of: 399dbcadc01e ("ACPI: battery: Add synchronization between interface updates") Signed-off-by: Sasha Levin <sashal@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/acpi/battery.c9
1 files changed, 2 insertions, 7 deletions
diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c
index c6e29e377b9c..1a10eeddedac 100644
--- a/drivers/acpi/battery.c
+++ b/drivers/acpi/battery.c
@@ -1225,8 +1225,8 @@ static int acpi_battery_add(struct acpi_device *device)
strscpy(acpi_device_name(device), ACPI_BATTERY_DEVICE_NAME);
strscpy(acpi_device_class(device), ACPI_BATTERY_CLASS);
device->driver_data = battery;
- mutex_init(&battery->lock);
- mutex_init(&battery->sysfs_lock);
+ devm_mutex_init(&device->dev, &battery->lock);
+ devm_mutex_init(&device->dev, &battery->sysfs_lock);
if (acpi_has_method(battery->device->handle, "_BIX"))
set_bit(ACPI_BATTERY_XINFO_PRESENT, &battery->flags);
@@ -1254,8 +1254,6 @@ fail_pm:
unregister_pm_notifier(&battery->pm_nb);
fail:
sysfs_remove_battery(battery);
- mutex_destroy(&battery->lock);
- mutex_destroy(&battery->sysfs_lock);
return result;
}
@@ -1275,9 +1273,6 @@ static void acpi_battery_remove(struct acpi_device *device)
device_init_wakeup(&device->dev, 0);
unregister_pm_notifier(&battery->pm_nb);
sysfs_remove_battery(battery);
-
- mutex_destroy(&battery->lock);
- mutex_destroy(&battery->sysfs_lock);
}
#ifdef CONFIG_PM_SLEEP