diff options
| author | Zhen Ni <zhen.ni@easystack.cn> | 2025-10-14 17:05:22 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2026-01-23 11:21:33 +0100 |
| commit | dd5d96722a967da35806dba22988f00cfe092db2 (patch) | |
| tree | fa855d456d505fc7b69b3323bd37a79fab82610f /drivers | |
| parent | eabe40f8a53c29f531e92778ea243e379f4f7978 (diff) | |
| download | linux-dd5d96722a967da35806dba22988f00cfe092db2.tar.gz linux-dd5d96722a967da35806dba22988f00cfe092db2.tar.bz2 linux-dd5d96722a967da35806dba22988f00cfe092db2.zip | |
dmaengine: fsl-edma: Fix clk leak on alloc_chan_resources failure
commit b18cd8b210417f90537d914ffb96e390c85a7379 upstream.
When fsl_edma_alloc_chan_resources() fails after clk_prepare_enable(),
the error paths only free IRQs and destroy the TCD pool, but forget to
call clk_disable_unprepare(). This causes the channel clock to remain
enabled, leaking power and resources.
Fix it by disabling the channel clock in the error unwind path.
Fixes: d8d4355861d8 ("dmaengine: fsl-edma: add i.MX8ULP edma support")
Cc: stable@vger.kernel.org
Suggested-by: Frank Li <Frank.Li@nxp.com>
Signed-off-by: Zhen Ni <zhen.ni@easystack.cn>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
Link: https://patch.msgid.link/20251014090522.827726-1-zhen.ni@easystack.cn
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/dma/fsl-edma-common.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/dma/fsl-edma-common.c b/drivers/dma/fsl-edma-common.c index 4976d7dde080..11655dcc4d6c 100644 --- a/drivers/dma/fsl-edma-common.c +++ b/drivers/dma/fsl-edma-common.c @@ -852,6 +852,7 @@ err_errirq: free_irq(fsl_chan->txirq, fsl_chan); err_txirq: dma_pool_destroy(fsl_chan->tcd_pool); + clk_disable_unprepare(fsl_chan->clk); return ret; } |