summaryrefslogtreecommitdiff
path: root/drivers
diff options
context:
space:
mode:
authorWentao Liang <vulab@iscas.ac.cn>2025-04-08 11:26:02 +0800
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2025-06-27 11:08:57 +0100
commit42d0bfbe029640fb1227ba9b310a271bc0ee589d (patch)
tree4f51508d6a8f170de96740dbed4dfcd2e94c5712 /drivers
parenta37888a435b0737128d2d9c6f67b8d608f83df7a (diff)
downloadlinux-42d0bfbe029640fb1227ba9b310a271bc0ee589d.tar.gz
linux-42d0bfbe029640fb1227ba9b310a271bc0ee589d.tar.bz2
linux-42d0bfbe029640fb1227ba9b310a271bc0ee589d.zip
octeontx2-pf: Add error log forcn10k_map_unmap_rq_policer()
[ Upstream commit 9c056ec6dd1654b1420dafbbe2a69718850e6ff2 ] The cn10k_free_matchall_ipolicer() calls the cn10k_map_unmap_rq_policer() for each queue in a for loop without checking for any errors. Check the return value of the cn10k_map_unmap_rq_policer() function during each loop, and report a warning if the function fails. Signed-off-by: Wentao Liang <vulab@iscas.ac.cn> Reviewed-by: Simon Horman <horms@kernel.org> Link: https://patch.msgid.link/20250408032602.2909-1-vulab@iscas.ac.cn Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/net/ethernet/marvell/octeontx2/nic/cn10k.c9
1 files changed, 6 insertions, 3 deletions
diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/cn10k.c b/drivers/net/ethernet/marvell/octeontx2/nic/cn10k.c
index 7417087b6db5..a2807a1e4f4a 100644
--- a/drivers/net/ethernet/marvell/octeontx2/nic/cn10k.c
+++ b/drivers/net/ethernet/marvell/octeontx2/nic/cn10k.c
@@ -352,9 +352,12 @@ int cn10k_free_matchall_ipolicer(struct otx2_nic *pfvf)
mutex_lock(&pfvf->mbox.lock);
/* Remove RQ's policer mapping */
- for (qidx = 0; qidx < hw->rx_queues; qidx++)
- cn10k_map_unmap_rq_policer(pfvf, qidx,
- hw->matchall_ipolicer, false);
+ for (qidx = 0; qidx < hw->rx_queues; qidx++) {
+ rc = cn10k_map_unmap_rq_policer(pfvf, qidx, hw->matchall_ipolicer, false);
+ if (rc)
+ dev_warn(pfvf->dev, "Failed to unmap RQ %d's policer (error %d).",
+ qidx, rc);
+ }
rc = cn10k_free_leaf_profile(pfvf, hw->matchall_ipolicer);