summaryrefslogtreecommitdiff
path: root/fs/ceph
diff options
context:
space:
mode:
authorXiubo Li <xiubli@redhat.com>2024-09-05 06:22:18 +0800
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2024-10-10 11:57:14 +0200
commit11ab19d48ab877430eed0c7d83810970bbcbc4f6 (patch)
tree2a28d5e49857cb08fd4795eaa717253aeb034b55 /fs/ceph
parent10a58555e0bb5cc4673c8bb73b8afc5fa651f0ac (diff)
downloadlinux-11ab19d48ab877430eed0c7d83810970bbcbc4f6.tar.gz
linux-11ab19d48ab877430eed0c7d83810970bbcbc4f6.tar.bz2
linux-11ab19d48ab877430eed0c7d83810970bbcbc4f6.zip
ceph: remove the incorrect Fw reference check when dirtying pages
[ Upstream commit c08dfb1b49492c09cf13838c71897493ea3b424e ] When doing the direct-io reads it will also try to mark pages dirty, but for the read path it won't hold the Fw caps and there is case will it get the Fw reference. Fixes: 5dda377cf0a6 ("ceph: set i_head_snapc when getting CEPH_CAP_FILE_WR reference") Signed-off-by: Xiubo Li <xiubli@redhat.com> Reviewed-by: Patrick Donnelly <pdonnell@redhat.com> Signed-off-by: Ilya Dryomov <idryomov@gmail.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'fs/ceph')
-rw-r--r--fs/ceph/addr.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c
index da64bb7325db..7549e2b07b6a 100644
--- a/fs/ceph/addr.c
+++ b/fs/ceph/addr.c
@@ -95,7 +95,6 @@ static bool ceph_dirty_folio(struct address_space *mapping, struct folio *folio)
/* dirty the head */
spin_lock(&ci->i_ceph_lock);
- BUG_ON(ci->i_wr_ref == 0); // caller should hold Fw reference
if (__ceph_have_pending_cap_snap(ci)) {
struct ceph_cap_snap *capsnap =
list_last_entry(&ci->i_cap_snaps,