summaryrefslogtreecommitdiff
path: root/fs
diff options
context:
space:
mode:
authorTetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>2025-08-13 00:17:44 +0900
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2025-10-29 14:01:14 +0100
commit8568e6387f6afe273fb353cd541789d30faa4a8a (patch)
tree7acc5785e7e3d80d2962d76914a41c4dcc500259 /fs
parent5c64c0b7b3446f7ed088a13bc8d7487d66534cbb (diff)
downloadlinux-8568e6387f6afe273fb353cd541789d30faa4a8a.tar.gz
linux-8568e6387f6afe273fb353cd541789d30faa4a8a.tar.bz2
linux-8568e6387f6afe273fb353cd541789d30faa4a8a.zip
minixfs: Verify inode mode when loading from disk
[ Upstream commit 73861970938ad1323eb02bbbc87f6fbd1e5bacca ] The inode mode loaded from corrupted disk can be invalid. Do like what commit 0a9e74051313 ("isofs: Verify inode mode when loading from disk") does. Reported-by: syzbot <syzbot+895c23f6917da440ed0d@syzkaller.appspotmail.com> Closes: https://syzkaller.appspot.com/bug?extid=895c23f6917da440ed0d Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> Link: https://lore.kernel.org/ec982681-84b8-4624-94fa-8af15b77cbd2@I-love.SAKURA.ne.jp Signed-off-by: Christian Brauner <brauner@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'fs')
-rw-r--r--fs/minix/inode.c8
1 files changed, 7 insertions, 1 deletions
diff --git a/fs/minix/inode.c b/fs/minix/inode.c
index e938f5b1e4b9..7636e789eb49 100644
--- a/fs/minix/inode.c
+++ b/fs/minix/inode.c
@@ -469,8 +469,14 @@ void minix_set_inode(struct inode *inode, dev_t rdev)
inode->i_op = &minix_symlink_inode_operations;
inode_nohighmem(inode);
inode->i_mapping->a_ops = &minix_aops;
- } else
+ } else if (S_ISCHR(inode->i_mode) || S_ISBLK(inode->i_mode) ||
+ S_ISFIFO(inode->i_mode) || S_ISSOCK(inode->i_mode)) {
init_special_inode(inode, inode->i_mode, rdev);
+ } else {
+ printk(KERN_DEBUG "MINIX-fs: Invalid file type 0%04o for inode %lu.\n",
+ inode->i_mode, inode->i_ino);
+ make_bad_inode(inode);
+ }
}
/*