summaryrefslogtreecommitdiff
path: root/fs
diff options
context:
space:
mode:
authorVasiliy Kovalev <kovalev@altlinux.org>2024-11-19 18:58:17 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2024-12-14 19:44:43 +0100
commitf9248e2f73fb4afe08324485e98c815ac084d166 (patch)
treec1dbc4115a3fd50dc2893f2e99f545ff30d7aa9f /fs
parentcf642904be39ae0d441dbdfa8f485e0a46260be4 (diff)
downloadlinux-f9248e2f73fb4afe08324485e98c815ac084d166.tar.gz
linux-f9248e2f73fb4afe08324485e98c815ac084d166.tar.bz2
linux-f9248e2f73fb4afe08324485e98c815ac084d166.zip
ovl: Filter invalid inodes with missing lookup function
commit c8b359dddb418c60df1a69beea01d1b3322bfe83 upstream. Add a check to the ovl_dentry_weird() function to prevent the processing of directory inodes that lack the lookup function. This is important because such inodes can cause errors in overlayfs when passed to the lowerstack. Reported-by: syzbot+a8c9d476508bd14a90e5@syzkaller.appspotmail.com Link: https://syzkaller.appspot.com/bug?extid=a8c9d476508bd14a90e5 Suggested-by: Miklos Szeredi <miklos@szeredi.hu> Link: https://lore.kernel.org/linux-unionfs/CAJfpegvx-oS9XGuwpJx=Xe28_jzWx5eRo1y900_ZzWY+=gGzUg@mail.gmail.com/ Signed-off-by: Vasiliy Kovalev <kovalev@altlinux.org> Cc: <stable@vger.kernel.org> Signed-off-by: Amir Goldstein <amir73il@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'fs')
-rw-r--r--fs/overlayfs/util.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/fs/overlayfs/util.c b/fs/overlayfs/util.c
index f5678a3f8350..4d75e1cdf0b9 100644
--- a/fs/overlayfs/util.c
+++ b/fs/overlayfs/util.c
@@ -111,6 +111,9 @@ bool ovl_dentry_remote(struct dentry *dentry)
bool ovl_dentry_weird(struct dentry *dentry)
{
+ if (!d_can_lookup(dentry) && !d_is_file(dentry) && !d_is_symlink(dentry))
+ return true;
+
return dentry->d_flags & (DCACHE_NEED_AUTOMOUNT |
DCACHE_MANAGE_TRANSIT |
DCACHE_OP_HASH |