diff options
| author | Pali Rohár <pali@kernel.org> | 2024-10-06 19:30:01 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2024-12-05 14:03:07 +0100 |
| commit | cc0075cf26b59cf0cdd1b1235d5d1bd5cfb83b4f (patch) | |
| tree | e2fcc7970ccfee3d964449d1f0b7327843b6bae6 /fs | |
| parent | fc5a409552be479715b147748f2f61b41b512976 (diff) | |
| download | linux-cc0075cf26b59cf0cdd1b1235d5d1bd5cfb83b4f.tar.gz linux-cc0075cf26b59cf0cdd1b1235d5d1bd5cfb83b4f.tar.bz2 linux-cc0075cf26b59cf0cdd1b1235d5d1bd5cfb83b4f.zip | |
cifs: Fix parsing reparse point with native symlink in SMB1 non-UNICODE session
[ Upstream commit f4ca4f5a36eac9b4da378a0f28cbbe38534a0901 ]
SMB1 NT_TRANSACT_IOCTL/FSCTL_GET_REPARSE_POINT even in non-UNICODE mode
returns reparse buffer in UNICODE/UTF-16 format.
This is because FSCTL_GET_REPARSE_POINT is NT-based IOCTL which does not
distinguish between 8-bit non-UNICODE and 16-bit UNICODE modes and its path
buffers are always encoded in UTF-16.
This change fixes reading of native symlinks in SMB1 when UNICODE session
is not active.
Fixes: ed3e0a149b58 ("smb: client: implement ->query_reparse_point() for SMB1")
Signed-off-by: Pali Rohár <pali@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/smb/client/smb1ops.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/fs/smb/client/smb1ops.c b/fs/smb/client/smb1ops.c index abca214f923c..db3695eddcf9 100644 --- a/fs/smb/client/smb1ops.c +++ b/fs/smb/client/smb1ops.c @@ -1000,12 +1000,11 @@ static int cifs_parse_reparse_point(struct cifs_sb_info *cifs_sb, { struct reparse_data_buffer *buf; TRANSACT_IOCTL_RSP *io = rsp_iov->iov_base; - bool unicode = !!(io->hdr.Flags2 & SMBFLG2_UNICODE); u32 plen = le16_to_cpu(io->ByteCount); buf = (struct reparse_data_buffer *)((__u8 *)&io->hdr.Protocol + le32_to_cpu(io->DataOffset)); - return parse_reparse_point(buf, plen, cifs_sb, full_path, unicode, data); + return parse_reparse_point(buf, plen, cifs_sb, full_path, true, data); } static bool |