diff options
| author | Dominik Brodowski <linux@dominikbrodowski.net> | 2021-12-31 09:26:08 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2022-06-22 14:11:06 +0200 |
| commit | 8b4695640bc56a88b2dc76a1ec4ab2a6b709c7f0 (patch) | |
| tree | 042fe0b8449f2c1cc8622e8062fc03e6aa8eccb3 /include/crypto | |
| parent | cfc69065005ea11e39f80c463519787977e376a1 (diff) | |
| download | linux-8b4695640bc56a88b2dc76a1ec4ab2a6b709c7f0.tar.gz linux-8b4695640bc56a88b2dc76a1ec4ab2a6b709c7f0.tar.bz2 linux-8b4695640bc56a88b2dc76a1ec4ab2a6b709c7f0.zip | |
random: early initialization of ChaCha constants
commit 96562f286884e2db89c74215b199a1084b5fb7f7 upstream.
Previously, the ChaCha constants for the primary pool were only
initialized in crng_initialize_primary(), called by rand_initialize().
However, some randomness is actually extracted from the primary pool
beforehand, e.g. by kmem_cache_create(). Therefore, statically
initialize the ChaCha constants for the primary pool.
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: <linux-crypto@vger.kernel.org>
Signed-off-by: Dominik Brodowski <linux@dominikbrodowski.net>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'include/crypto')
| -rw-r--r-- | include/crypto/chacha.h | 15 |
1 files changed, 11 insertions, 4 deletions
diff --git a/include/crypto/chacha.h b/include/crypto/chacha.h index d517ea4be167..542f896115f4 100644 --- a/include/crypto/chacha.h +++ b/include/crypto/chacha.h @@ -51,12 +51,19 @@ int crypto_chacha12_setkey(struct crypto_skcipher *tfm, const u8 *key, int crypto_chacha_crypt(struct skcipher_request *req); int crypto_xchacha_crypt(struct skcipher_request *req); +enum chacha_constants { /* expand 32-byte k */ + CHACHA_CONSTANT_EXPA = 0x61707865U, + CHACHA_CONSTANT_ND_3 = 0x3320646eU, + CHACHA_CONSTANT_2_BY = 0x79622d32U, + CHACHA_CONSTANT_TE_K = 0x6b206574U +}; + static inline void chacha_init_consts(u32 *state) { - state[0] = 0x61707865; /* "expa" */ - state[1] = 0x3320646e; /* "nd 3" */ - state[2] = 0x79622d32; /* "2-by" */ - state[3] = 0x6b206574; /* "te k" */ + state[0] = CHACHA_CONSTANT_EXPA; + state[1] = CHACHA_CONSTANT_ND_3; + state[2] = CHACHA_CONSTANT_2_BY; + state[3] = CHACHA_CONSTANT_TE_K; } #endif /* _CRYPTO_CHACHA_H */ |