diff options
| author | Herbert Xu <herbert@gondor.apana.org.au> | 2025-09-16 17:20:59 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2025-09-25 11:00:07 +0200 |
| commit | 7c4491b5644e3a3708f3dbd7591be0a570135b84 (patch) | |
| tree | 82f94aa9287956436b54b2caa1279449ace261b9 /include/crypto | |
| parent | ee74d69af1707030cc409f1a07b79fd1d3aa24b4 (diff) | |
| download | linux-7c4491b5644e3a3708f3dbd7591be0a570135b84.tar.gz linux-7c4491b5644e3a3708f3dbd7591be0a570135b84.tar.bz2 linux-7c4491b5644e3a3708f3dbd7591be0a570135b84.zip | |
crypto: af_alg - Disallow concurrent writes in af_alg_sendmsg
commit 1b34cbbf4f011a121ef7b2d7d6e6920a036d5285 upstream.
Issuing two writes to the same af_alg socket is bogus as the
data will be interleaved in an unpredictable fashion. Furthermore,
concurrent writes may create inconsistencies in the internal
socket state.
Disallow this by adding a new ctx->write field that indiciates
exclusive ownership for writing.
Fixes: 8ff590903d5 ("crypto: algif_skcipher - User-space interface for skcipher operations")
Reported-by: Muhammad Alifa Ramdhan <ramdhan@starlabs.sg>
Reported-by: Bing-Jhong Billy Jheng <billy@starlabs.sg>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'include/crypto')
| -rw-r--r-- | include/crypto/if_alg.h | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/include/crypto/if_alg.h b/include/crypto/if_alg.h index 08b803a4fcde..7402bf3e037e 100644 --- a/include/crypto/if_alg.h +++ b/include/crypto/if_alg.h @@ -134,6 +134,7 @@ struct af_alg_async_req { * SG? * @enc: Cryptographic operation to be performed when * recvmsg is invoked. + * @write: True if we are in the middle of a write. * @init: True if metadata has been sent. * @len: Length of memory allocated for this data structure. * @inflight: Non-zero when AIO requests are in flight. @@ -149,10 +150,11 @@ struct af_alg_ctx { size_t used; atomic_t rcvused; - bool more; - bool merge; - bool enc; - bool init; + u32 more:1, + merge:1, + enc:1, + write:1, + init:1; unsigned int len; |