diff options
| author | Xiaomeng Tong <xiam0nd.tong@gmail.com> | 2022-05-01 21:28:23 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2022-06-09 10:21:26 +0200 |
| commit | e9514bce2fb78edac76db738f5eca66dd1165c19 (patch) | |
| tree | 8de3d6784201560bfff25571d0fcea0129e19a7e /include | |
| parent | 82c888e51c2176a06f8b4541cf748ee81aac6e7e (diff) | |
| download | linux-e9514bce2fb78edac76db738f5eca66dd1165c19.tar.gz linux-e9514bce2fb78edac76db738f5eca66dd1165c19.tar.bz2 linux-e9514bce2fb78edac76db738f5eca66dd1165c19.zip | |
iommu/msm: Fix an incorrect NULL check on list iterator
commit 8b9ad480bd1dd25f4ff4854af5685fa334a2f57a upstream.
The bug is here:
if (!iommu || iommu->dev->of_node != spec->np) {
The list iterator value 'iommu' will *always* be set and non-NULL by
list_for_each_entry(), so it is incorrect to assume that the iterator
value will be NULL if the list is empty or no element is found (in fact,
it will point to a invalid structure object containing HEAD).
To fix the bug, use a new value 'iter' as the list iterator, while use
the old value 'iommu' as a dedicated variable to point to the found one,
and remove the unneeded check for 'iommu->dev->of_node != spec->np'
outside the loop.
Cc: stable@vger.kernel.org
Fixes: f78ebca8ff3d6 ("iommu/msm: Add support for generic master bindings")
Signed-off-by: Xiaomeng Tong <xiam0nd.tong@gmail.com>
Link: https://lore.kernel.org/r/20220501132823.12714-1-xiam0nd.tong@gmail.com
Signed-off-by: Joerg Roedel <jroedel@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'include')
0 files changed, 0 insertions, 0 deletions