diff options
| author | Jens Axboe <axboe@kernel.dk> | 2025-03-20 12:25:12 -0600 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2025-03-28 22:03:29 +0100 |
| commit | 66e3cc3885e85153508a1066146a0b1c354fa5fc (patch) | |
| tree | 8c425354f30be5c5b74c1c99d43af5ca715ac7d2 /io_uring | |
| parent | 4b4d2527840f088a8df19027a6c208f4122a7106 (diff) | |
| download | linux-66e3cc3885e85153508a1066146a0b1c354fa5fc.tar.gz linux-66e3cc3885e85153508a1066146a0b1c354fa5fc.tar.bz2 linux-66e3cc3885e85153508a1066146a0b1c354fa5fc.zip | |
io_uring/net: don't clear REQ_F_NEED_CLEANUP unconditionally
commit cc34d8330e036b6bffa88db9ea537bae6b03948f upstream.
io_req_msg_cleanup() relies on the fact that io_netmsg_recycle() will
always fully recycle, but that may not be the case if the msg cache
was already full. To ensure that normal cleanup always gets run,
let io_netmsg_recycle() deal with clearing the relevant cleanup flags,
as it knows exactly when that should be done.
Cc: stable@vger.kernel.org
Reported-by: David Wei <dw@davidwei.uk>
Fixes: 75191341785e ("io_uring/net: add iovec recycling")
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'io_uring')
| -rw-r--r-- | io_uring/net.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/io_uring/net.c b/io_uring/net.c index f32311f64113..0d14e2756cce 100644 --- a/io_uring/net.c +++ b/io_uring/net.c @@ -152,7 +152,7 @@ static void io_netmsg_recycle(struct io_kiocb *req, unsigned int issue_flags) if (iov) kasan_mempool_poison_object(iov); req->async_data = NULL; - req->flags &= ~REQ_F_ASYNC_DATA; + req->flags &= ~(REQ_F_ASYNC_DATA|REQ_F_NEED_CLEANUP); } } @@ -447,7 +447,6 @@ int io_sendmsg_prep(struct io_kiocb *req, const struct io_uring_sqe *sqe) static void io_req_msg_cleanup(struct io_kiocb *req, unsigned int issue_flags) { - req->flags &= ~REQ_F_NEED_CLEANUP; io_netmsg_recycle(req, issue_flags); } |