diff options
| author | Amir Goldstein <amir73il@gmail.com> | 2021-10-25 16:27:18 -0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2024-04-10 16:18:49 +0200 |
| commit | 18370157880b31b9cc3e41d51c8540ec6f7fd857 (patch) | |
| tree | 9caf970b1989b418ca40bc76090b9765c163a56d /kernel/audit_watch.c | |
| parent | d92a8789fef64b08044c7041e131712410ac2be5 (diff) | |
| download | linux-18370157880b31b9cc3e41d51c8540ec6f7fd857.tar.gz linux-18370157880b31b9cc3e41d51c8540ec6f7fd857.tar.bz2 linux-18370157880b31b9cc3e41d51c8540ec6f7fd857.zip | |
fsnotify: clarify contract for create event hooks
[ Upstream commit dabe729dddca550446e9cc118c96d1f91703345b ]
Clarify argument names and contract for fsnotify_create() and
fsnotify_mkdir() to reflect the anomaly of kernfs, which leaves dentries
negavite after mkdir/create.
Remove the WARN_ON(!inode) in audit code that were added by the Fixes
commit under the wrong assumption that dentries cannot be negative after
mkdir/create.
Fixes: aa93bdc5500c ("fsnotify: use helpers to access data by data_type")
Link: https://lore.kernel.org/linux-fsdevel/87mtp5yz0q.fsf@collabora.com/
Link: https://lore.kernel.org/r/20211025192746.66445-4-krisman@collabora.com
Reviewed-by: Jan Kara <jack@suse.cz>
Reported-by: Gabriel Krisman Bertazi <krisman@collabora.com>
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.com>
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Diffstat (limited to 'kernel/audit_watch.c')
| -rw-r--r-- | kernel/audit_watch.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/kernel/audit_watch.c b/kernel/audit_watch.c index edbeffee64b8..fd7b30a2d9a4 100644 --- a/kernel/audit_watch.c +++ b/kernel/audit_watch.c @@ -472,8 +472,7 @@ static int audit_watch_handle_event(struct fsnotify_mark *inode_mark, u32 mask, parent = container_of(inode_mark, struct audit_parent, mark); - if (WARN_ON_ONCE(inode_mark->group != audit_watch_group) || - WARN_ON_ONCE(!inode)) + if (WARN_ON_ONCE(inode_mark->group != audit_watch_group)) return 0; if (mask & (FS_CREATE|FS_MOVED_TO) && inode) |