diff options
| author | Zheng Yejian <zhengyejian@huaweicloud.com> | 2024-08-27 20:46:54 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2024-09-12 11:03:56 +0200 |
| commit | 7195d0498d1ce42f6e026871b749992c3213bb53 (patch) | |
| tree | 3ac13dee7b2bf734fab8226ae87ae98bdd157f38 /kernel | |
| parent | 2feb2c351c2c4d6cdd648c9a132b6553e8372f34 (diff) | |
| download | linux-7195d0498d1ce42f6e026871b749992c3213bb53.tar.gz linux-7195d0498d1ce42f6e026871b749992c3213bb53.tar.bz2 linux-7195d0498d1ce42f6e026871b749992c3213bb53.zip | |
tracing: Avoid possible softlockup in tracing_iter_reset()
[ Upstream commit 49aa8a1f4d6800721c7971ed383078257f12e8f9 ]
In __tracing_open(), when max latency tracers took place on the cpu,
the time start of its buffer would be updated, then event entries with
timestamps being earlier than start of the buffer would be skipped
(see tracing_iter_reset()).
Softlockup will occur if the kernel is non-preemptible and too many
entries were skipped in the loop that reset every cpu buffer, so add
cond_resched() to avoid it.
Cc: stable@vger.kernel.org
Fixes: 2f26ebd549b9a ("tracing: use timestamp to determine start of latency traces")
Link: https://lore.kernel.org/20240827124654.3817443-1-zhengyejian@huaweicloud.com
Suggested-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Zheng Yejian <zhengyejian@huaweicloud.com>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'kernel')
| -rw-r--r-- | kernel/trace/trace.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index 8bf28d482abe..67466563d86f 100644 --- a/kernel/trace/trace.c +++ b/kernel/trace/trace.c @@ -3487,6 +3487,8 @@ void tracing_iter_reset(struct trace_iterator *iter, int cpu) break; entries++; ring_buffer_iter_advance(buf_iter); + /* This could be a big loop */ + cond_resched(); } per_cpu_ptr(iter->trace_buffer->data, cpu)->skipped_entries = entries; |