diff options
| author | Thomas Gleixner <tglx@linutronix.de> | 2025-08-02 12:39:39 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2025-08-15 12:14:09 +0200 |
| commit | 8c67899a52955c1a753a007b890e26aca9d1a209 (patch) | |
| tree | 2a7dcb88ee0980b0e3ad6b5a5938ffdf51ad1cf7 /kernel | |
| parent | 25bb3647d30a20486b5fe7cff2b0e503c16c9692 (diff) | |
| download | linux-8c67899a52955c1a753a007b890e26aca9d1a209.tar.gz linux-8c67899a52955c1a753a007b890e26aca9d1a209.tar.bz2 linux-8c67899a52955c1a753a007b890e26aca9d1a209.zip | |
perf/core: Don't leak AUX buffer refcount on allocation failure
commit 5468c0fbccbb9d156522c50832244a8b722374fb upstream.
Failure of the AUX buffer allocation leaks the reference count.
Set the reference count to 1 only when the allocation succeeds.
Fixes: 45bfb2e50471 ("perf/core: Add AUX area to ring buffer for raw data streams")
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Cc: stable@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'kernel')
| -rw-r--r-- | kernel/events/core.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/kernel/events/core.c b/kernel/events/core.c index dd745485b0f4..b606680370ca 100644 --- a/kernel/events/core.c +++ b/kernel/events/core.c @@ -6713,9 +6713,7 @@ static int perf_mmap(struct file *file, struct vm_area_struct *vma) goto unlock; } - atomic_set(&rb->aux_mmap_count, 1); user_extra = nr_pages; - goto accounting; } @@ -6817,8 +6815,10 @@ accounting: } else { ret = rb_alloc_aux(rb, event, vma->vm_pgoff, nr_pages, event->attr.aux_watermark, flags); - if (!ret) + if (!ret) { + atomic_set(&rb->aux_mmap_count, 1); rb->aux_mmap_locked = extra; + } } unlock: @@ -6828,6 +6828,7 @@ unlock: atomic_inc(&event->mmap_count); } else if (rb) { + /* AUX allocation failed */ atomic_dec(&rb->mmap_count); } aux_unlock: |