diff options
| author | Simon Horman <horms@kernel.org> | 2025-06-13 17:46:20 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2025-06-27 11:04:21 +0100 |
| commit | 9aea0a0009e47d2a08e8924e35a4adccd46ff0ed (patch) | |
| tree | b0ff3864959edd00a7e2084e3f6f43e736955abc /lib | |
| parent | 2ce859f13d62d26c1e42e0794b5d19a2a74e0a7a (diff) | |
| download | linux-9aea0a0009e47d2a08e8924e35a4adccd46ff0ed.tar.gz linux-9aea0a0009e47d2a08e8924e35a4adccd46ff0ed.tar.bz2 linux-9aea0a0009e47d2a08e8924e35a4adccd46ff0ed.zip | |
pldmfw: Select CRC32 when PLDMFW is selected
[ Upstream commit 1224b218a4b9203656ecc932152f4c81a97b4fcc ]
pldmfw calls crc32 code and depends on it being enabled, else
there is a link error as follows. So PLDMFW should select CRC32.
lib/pldmfw/pldmfw.o: In function `pldmfw_flash_image':
pldmfw.c:(.text+0x70f): undefined reference to `crc32_le_base'
This problem was introduced by commit b8265621f488 ("Add pldmfw library
for PLDM firmware update").
It manifests as of commit d69ea414c9b4 ("ice: implement device flash
update via devlink").
And is more likely to occur as of commit 9ad19171b6d6 ("lib/crc: remove
unnecessary prompt for CONFIG_CRC32 and drop 'default y'").
Found by chance while exercising builds based on tinyconfig.
Fixes: b8265621f488 ("Add pldmfw library for PLDM firmware update")
Signed-off-by: Simon Horman <horms@kernel.org>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Link: https://patch.msgid.link/20250613-pldmfw-crc32-v1-1-f3fad109eee6@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/Kconfig | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/lib/Kconfig b/lib/Kconfig index 36326864249d..4f280d0d93db 100644 --- a/lib/Kconfig +++ b/lib/Kconfig @@ -692,4 +692,5 @@ config GENERIC_LIB_UCMPDI2 config PLDMFW bool + select CRC32 default n |