diff options
| author | David Gow <davidgow@google.com> | 2024-02-21 17:27:15 +0800 |
|---|---|---|
| committer | Sasha Levin <sashal@kernel.org> | 2024-03-26 18:21:15 -0400 |
| commit | 770332c1fd0a6424e2c3de43fe59e313c51b3702 (patch) | |
| tree | c1cbb4200bc71216fc8c5e4f00e8798847d31ba4 /lib | |
| parent | 01db522d003fb5699f5033128f7df88bf0ab2fc8 (diff) | |
| download | linux-770332c1fd0a6424e2c3de43fe59e313c51b3702.tar.gz linux-770332c1fd0a6424e2c3de43fe59e313c51b3702.tar.bz2 linux-770332c1fd0a6424e2c3de43fe59e313c51b3702.zip | |
lib/cmdline: Fix an invalid format specifier in an assertion msg
[ Upstream commit d2733a026fc7247ba42d7a8e1b737cf14bf1df21 ]
The correct format specifier for p - n (both p and n are pointers) is
%td, as the type should be ptrdiff_t.
This was discovered by annotating KUnit assertion macros with gcc's
printf specifier, but note that gcc incorrectly suggested a %d or %ld
specifier (depending on the pointer size of the architecture being
built).
Fixes: 0ea09083116d ("lib/cmdline: Allow get_options() to take 0 to validate the input")
Signed-off-by: David Gow <davidgow@google.com>
Tested-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Daniel Latypov <dlatypov@google.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/cmdline_kunit.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/cmdline_kunit.c b/lib/cmdline_kunit.c index a72a2c16066e..de7fb7476cb9 100644 --- a/lib/cmdline_kunit.c +++ b/lib/cmdline_kunit.c @@ -124,7 +124,7 @@ static void cmdline_do_one_range_test(struct kunit *test, const char *in, n, e[0], r[0]); p = memchr_inv(&r[1], 0, sizeof(r) - sizeof(r[0])); - KUNIT_EXPECT_PTR_EQ_MSG(test, p, NULL, "in test %u at %u out of bound", n, p - r); + KUNIT_EXPECT_PTR_EQ_MSG(test, p, NULL, "in test %u at %td out of bound", n, p - r); } static void cmdline_test_range(struct kunit *test) |