diff options
| author | Li Qiong <liqiong@nfschina.com> | 2025-09-06 22:27:33 -0400 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2025-09-09 18:45:22 +0200 |
| commit | f66012909e7bf383fcdc5850709ed5716073fdc4 (patch) | |
| tree | 93be3eac1142f0b986bcc3e19d24c0296818a998 /mm | |
| parent | cee956ab1efbd858b4ca61c8b474af5aa24b29a6 (diff) | |
| download | linux-f66012909e7bf383fcdc5850709ed5716073fdc4.tar.gz linux-f66012909e7bf383fcdc5850709ed5716073fdc4.tar.bz2 linux-f66012909e7bf383fcdc5850709ed5716073fdc4.zip | |
mm/slub: avoid accessing metadata when pointer is invalid in object_err()
[ Upstream commit b4efccec8d06ceb10a7d34d7b1c449c569d53770 ]
object_err() reports details of an object for further debugging, such as
the freelist pointer, redzone, etc. However, if the pointer is invalid,
attempting to access object metadata can lead to a crash since it does
not point to a valid object.
One known path to the crash is when alloc_consistency_checks()
determines the pointer to the allocated object is invalid because of a
freelist corruption, and calls object_err() to report it. The debug code
should report and handle the corruption gracefully and not crash in the
process.
In case the pointer is NULL or check_valid_pointer() returns false for
the pointer, only print the pointer value and skip accessing metadata.
Fixes: 81819f0fc828 ("SLUB core")
Cc: <stable@vger.kernel.org>
Signed-off-by: Li Qiong <liqiong@nfschina.com>
Reviewed-by: Harry Yoo <harry.yoo@oracle.com>
Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Signed-off-by: Vlastimil Babka <vbabka@suse.cz>
[ struct page + print_page_info() ]
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'mm')
| -rw-r--r-- | mm/slub.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/mm/slub.c b/mm/slub.c index b0f637519ac9..30daba09da35 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -729,7 +729,12 @@ void object_err(struct kmem_cache *s, struct page *page, u8 *object, char *reason) { slab_bug(s, "%s", reason); - print_trailer(s, page, object); + if (!object || !check_valid_pointer(s, page, object)) { + print_page_info(page); + pr_err("Invalid pointer 0x%p\n", object); + } else { + print_trailer(s, page, object); + } } static __printf(3, 4) void slab_err(struct kmem_cache *s, struct page *page, |