diff options
| author | Liu Shixin <liushixin2@huawei.com> | 2024-10-15 09:45:21 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2024-11-08 16:20:47 +0100 |
| commit | ba7f982cdb37ff5a7739dec85d7325ea66fc1496 (patch) | |
| tree | 822352a20ca1bb0f3622c49782b2163dda43b841 /mm | |
| parent | 085e68e97fb04a6ccfc30866e3a7c0040d6efd90 (diff) | |
| download | linux-ba7f982cdb37ff5a7739dec85d7325ea66fc1496.tar.gz linux-ba7f982cdb37ff5a7739dec85d7325ea66fc1496.tar.bz2 linux-ba7f982cdb37ff5a7739dec85d7325ea66fc1496.zip | |
mm/swapfile: skip HugeTLB pages for unuse_vma
commit 7528c4fb1237512ee18049f852f014eba80bbe8d upstream.
I got a bad pud error and lost a 1GB HugeTLB when calling swapoff. The
problem can be reproduced by the following steps:
1. Allocate an anonymous 1GB HugeTLB and some other anonymous memory.
2. Swapout the above anonymous memory.
3. run swapoff and we will get a bad pud error in kernel message:
mm/pgtable-generic.c:42: bad pud 00000000743d215d(84000001400000e7)
We can tell that pud_clear_bad is called by pud_none_or_clear_bad in
unuse_pud_range() by ftrace. And therefore the HugeTLB pages will never
be freed because we lost it from page table. We can skip HugeTLB pages
for unuse_vma to fix it.
Link: https://lkml.kernel.org/r/20241015014521.570237-1-liushixin2@huawei.com
Fixes: 0fe6e20b9c4c ("hugetlb, rmap: add reverse mapping for hugepage")
Signed-off-by: Liu Shixin <liushixin2@huawei.com>
Acked-by: Muchun Song <muchun.song@linux.dev>
Cc: Naoya Horiguchi <nao.horiguchi@gmail.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'mm')
| -rw-r--r-- | mm/swapfile.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/mm/swapfile.c b/mm/swapfile.c index 5e444be061a8..68df5f360471 100644 --- a/mm/swapfile.c +++ b/mm/swapfile.c @@ -2091,7 +2091,7 @@ static int unuse_mm(struct mm_struct *mm, unsigned int type, down_read(&mm->mmap_sem); for (vma = mm->mmap; vma; vma = vma->vm_next) { - if (vma->anon_vma) { + if (vma->anon_vma && !is_vm_hugetlb_page(vma)) { ret = unuse_vma(vma, type, frontswap, fs_pages_to_unuse); if (ret) |