diff options
| author | Al Viro <viro@zeniv.linux.org.uk> | 2024-07-21 14:45:08 -0400 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2024-08-29 17:30:16 +0200 |
| commit | 43768fa80fd192558737e24ed6548f74554611d7 (patch) | |
| tree | 42f63e7f65e05d4d1860a626eee4806c0a2b38d7 /mm | |
| parent | 922fab508e37b725e083a504074122c2f63dbc79 (diff) | |
| download | linux-43768fa80fd192558737e24ed6548f74554611d7.tar.gz linux-43768fa80fd192558737e24ed6548f74554611d7.tar.bz2 linux-43768fa80fd192558737e24ed6548f74554611d7.zip | |
memcg_write_event_control(): fix a user-triggerable oops
commit 046667c4d3196938e992fba0dfcde570aa85cd0e upstream.
we are *not* guaranteed that anything past the terminating NUL
is mapped (let alone initialized with anything sane).
Fixes: 0dea116876ee ("cgroup: implement eventfd-based generic API for notifications")
Cc: stable@vger.kernel.org
Cc: Andrew Morton <akpm@linux-foundation.org>
Acked-by: Michal Hocko <mhocko@suse.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'mm')
| -rw-r--r-- | mm/memcontrol.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 4570d3e315cf..4ad6e8345b36 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -4857,9 +4857,12 @@ static ssize_t memcg_write_event_control(struct kernfs_open_file *of, buf = endp + 1; cfd = simple_strtoul(buf, &endp, 10); - if ((*endp != ' ') && (*endp != '\0')) + if (*endp == '\0') + buf = endp; + else if (*endp == ' ') + buf = endp + 1; + else return -EINVAL; - buf = endp + 1; event = kzalloc(sizeof(*event), GFP_KERNEL); if (!event) |