diff options
| author | Anirudh Gupta <anirudhrudr@gmail.com> | 2019-05-21 20:59:47 +0530 |
|---|---|---|
| committer | Ben Hutchings <ben@decadent.org.uk> | 2019-10-31 22:14:51 +0000 |
| commit | 53fa36261afe8c5e53367a80896a86412c52b5ed (patch) | |
| tree | 736ffb2dcc901d396064982fca093bce46a981a3 /net | |
| parent | 73a9a357fa49fa39f7e45e6e03077efaf5253233 (diff) | |
| download | linux-53fa36261afe8c5e53367a80896a86412c52b5ed.tar.gz linux-53fa36261afe8c5e53367a80896a86412c52b5ed.tar.bz2 linux-53fa36261afe8c5e53367a80896a86412c52b5ed.zip | |
xfrm: Fix xfrm sel prefix length validation
commit b38ff4075a80b4da5cb2202d7965332ca0efb213 upstream.
Family of src/dst can be different from family of selector src/dst.
Use xfrm selector family to validate address prefix length,
while verifying new sa from userspace.
Validated patch with this command:
ip xfrm state add src 1.1.6.1 dst 1.1.6.2 proto esp spi 4260196 \
reqid 20004 mode tunnel aead "rfc4106(gcm(aes))" \
0x1111016400000000000000000000000044440001 128 \
sel src 1011:1:4::2/128 sel dst 1021:1:4::2/128 dev Port5
Fixes: 07bf7908950a ("xfrm: Validate address prefix lengths in the xfrm selector.")
Signed-off-by: Anirudh Gupta <anirudh.gupta@sophos.com>
Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Diffstat (limited to 'net')
| -rw-r--r-- | net/xfrm/xfrm_user.c | 16 |
1 files changed, 16 insertions, 0 deletions
diff --git a/net/xfrm/xfrm_user.c b/net/xfrm/xfrm_user.c index b0f84a040f32..94dfcfd019f8 100644 --- a/net/xfrm/xfrm_user.c +++ b/net/xfrm/xfrm_user.c @@ -150,6 +150,22 @@ static int verify_newsa_info(struct xfrm_usersa_info *p, err = -EINVAL; switch (p->family) { case AF_INET: + break; + + case AF_INET6: +#if IS_ENABLED(CONFIG_IPV6) + break; +#else + err = -EAFNOSUPPORT; + goto out; +#endif + + default: + goto out; + } + + switch (p->sel.family) { + case AF_INET: if (p->sel.prefixlen_d > 32 || p->sel.prefixlen_s > 32) goto out; |