diff options
| author | Eric Dumazet <edumazet@google.com> | 2022-03-22 17:41:47 -0700 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2022-03-28 08:06:05 +0200 |
| commit | 0a7aad979bfb43c4a78d33a5f356caf4ceb28bca (patch) | |
| tree | 5ff36650cf6eb4427bf2d736999905dcf27bd566 /net | |
| parent | 7133e8468790b20cf5598de6b08174509aef3819 (diff) | |
| download | linux-0a7aad979bfb43c4a78d33a5f356caf4ceb28bca.tar.gz linux-0a7aad979bfb43c4a78d33a5f356caf4ceb28bca.tar.bz2 linux-0a7aad979bfb43c4a78d33a5f356caf4ceb28bca.zip | |
llc: fix netdevice reference leaks in llc_ui_bind()
commit 764f4eb6846f5475f1244767d24d25dd86528a4a upstream.
Whenever llc_ui_bind() and/or llc_ui_autobind()
took a reference on a netdevice but subsequently fail,
they must properly release their reference
or risk the infamous message from unregister_netdevice()
at device dismantle.
unregister_netdevice: waiting for eth0 to become free. Usage count = 3
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: 赵子轩 <beraphin@gmail.com>
Reported-by: Stoyan Manolov <smanolov@suse.de>
Link: https://lore.kernel.org/r/20220323004147.1990845-1-eric.dumazet@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'net')
| -rw-r--r-- | net/llc/af_llc.c | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/net/llc/af_llc.c b/net/llc/af_llc.c index a8866455e8b2..b922cf1a3ff7 100644 --- a/net/llc/af_llc.c +++ b/net/llc/af_llc.c @@ -309,6 +309,10 @@ static int llc_ui_autobind(struct socket *sock, struct sockaddr_llc *addr) sock_reset_flag(sk, SOCK_ZAPPED); rc = 0; out: + if (rc) { + dev_put(llc->dev); + llc->dev = NULL; + } return rc; } @@ -408,6 +412,10 @@ static int llc_ui_bind(struct socket *sock, struct sockaddr *uaddr, int addrlen) out_put: llc_sap_put(sap); out: + if (rc) { + dev_put(llc->dev); + llc->dev = NULL; + } release_sock(sk); return rc; } |