summaryrefslogtreecommitdiff
path: root/net
diff options
context:
space:
mode:
authorPhil Sutter <phil@nwl.cc>2023-09-29 21:19:19 +0200
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2023-11-20 11:08:15 +0100
commitbfd4ed4988aaa74a726a42b38a56ec5bdb63f7d9 (patch)
treed8036727d4b6bee56d516120305ff67e4cf5be62 /net
parent80986257d2cd135bee629152c3bfa3a7a23ac898 (diff)
downloadlinux-bfd4ed4988aaa74a726a42b38a56ec5bdb63f7d9.tar.gz
linux-bfd4ed4988aaa74a726a42b38a56ec5bdb63f7d9.tar.bz2
linux-bfd4ed4988aaa74a726a42b38a56ec5bdb63f7d9.zip
netfilter: nf_tables: Drop pointless memset when dumping rules
[ Upstream commit 30fa41a0f6df4c85790cc6499ddc4a926a113bfa ] None of the dump callbacks uses netlink_callback::args beyond the first element, no need to zero the data. Fixes: 96518518cc41 ("netfilter: add nftables") Signed-off-by: Phil Sutter <phil@nwl.cc> Signed-off-by: Florian Westphal <fw@strlen.de> Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'net')
-rw-r--r--net/netfilter/nf_tables_api.c4
1 files changed, 0 insertions, 4 deletions
diff --git a/net/netfilter/nf_tables_api.c b/net/netfilter/nf_tables_api.c
index 8a4cd1c16e0e..8f12e83280cb 100644
--- a/net/netfilter/nf_tables_api.c
+++ b/net/netfilter/nf_tables_api.c
@@ -3184,10 +3184,6 @@ static int __nf_tables_dump_rules(struct sk_buff *skb,
goto cont_skip;
if (*idx < s_idx)
goto cont;
- if (*idx > s_idx) {
- memset(&cb->args[1], 0,
- sizeof(cb->args) - sizeof(cb->args[0]));
- }
if (prule)
handle = prule->handle;
else