diff options
| author | Olga Kornievskaia <kolga@netapp.com> | 2022-04-21 10:32:34 -0400 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2022-05-12 12:32:33 +0200 |
| commit | bacdacb77155e690fe79755bdcc022d619d8df11 (patch) | |
| tree | 113bc29d8afadc0e4421bee7c1d76f7e436c6fc9 /net | |
| parent | 90c228f189ca3aa887684f5376a85a455d9b41c0 (diff) | |
| download | linux-bacdacb77155e690fe79755bdcc022d619d8df11.tar.gz linux-bacdacb77155e690fe79755bdcc022d619d8df11.tar.bz2 linux-bacdacb77155e690fe79755bdcc022d619d8df11.zip | |
SUNRPC release the transport of a relocated task with an assigned transport
commit e13433b4416fa31a24e621cbbbb39227a3d651dd upstream.
A relocated task must release its previous transport.
Fixes: 82ee41b85cef1 ("SUNRPC don't resend a task on an offlined transport")
Signed-off-by: Olga Kornievskaia <kolga@netapp.com>
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'net')
| -rw-r--r-- | net/sunrpc/clnt.c | 11 |
1 files changed, 7 insertions, 4 deletions
diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c index 0222ad4523a9..258ebc194ee2 100644 --- a/net/sunrpc/clnt.c +++ b/net/sunrpc/clnt.c @@ -1065,10 +1065,13 @@ rpc_task_get_next_xprt(struct rpc_clnt *clnt) static void rpc_task_set_transport(struct rpc_task *task, struct rpc_clnt *clnt) { - if (task->tk_xprt && - !(test_bit(XPRT_OFFLINE, &task->tk_xprt->state) && - (task->tk_flags & RPC_TASK_MOVEABLE))) - return; + if (task->tk_xprt) { + if (!(test_bit(XPRT_OFFLINE, &task->tk_xprt->state) && + (task->tk_flags & RPC_TASK_MOVEABLE))) + return; + xprt_release(task); + xprt_put(task->tk_xprt); + } if (task->tk_flags & RPC_TASK_NO_ROUND_ROBIN) task->tk_xprt = rpc_task_get_first_xprt(clnt); else |