diff options
| author | Johannes Berg <johannes.berg@intel.com> | 2024-05-23 12:11:40 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2024-09-08 07:56:32 +0200 |
| commit | 38c775a1eb337a7f8d4ba9c2fd16b2b22c92dc45 (patch) | |
| tree | 8da5cf0e660e6a2c4674679dff6a3c5085b3724a /net | |
| parent | deffdebd9a5a2f00a25940948a31c0fc3dfdb1d9 (diff) | |
| download | linux-38c775a1eb337a7f8d4ba9c2fd16b2b22c92dc45.tar.gz linux-38c775a1eb337a7f8d4ba9c2fd16b2b22c92dc45.tar.bz2 linux-38c775a1eb337a7f8d4ba9c2fd16b2b22c92dc45.zip | |
wifi: mac80211: check ieee80211_bss_info_change_notify() against MLD
[ Upstream commit a0ca76e5b7d550fcd74753d5fdaaf23f1a9bfdb4 ]
It's not valid to call ieee80211_bss_info_change_notify() with
an sdata that's an MLD, remove the FIXME comment (it's not true)
and add a warning.
Reviewed-by: Miriam Rachel Korenblit <miriam.rachel.korenblit@intel.com>
Link: https://msgid.link/20240523121140.97a589b13d24.I61988788d81fb3cf97a490dfd3167f67a141d1fd@changeid
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'net')
| -rw-r--r-- | net/mac80211/main.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/net/mac80211/main.c b/net/mac80211/main.c index 7ba329ebdda9..e44b2a26354b 100644 --- a/net/mac80211/main.c +++ b/net/mac80211/main.c @@ -337,6 +337,8 @@ void ieee80211_bss_info_change_notify(struct ieee80211_sub_if_data *sdata, might_sleep(); + WARN_ON_ONCE(ieee80211_vif_is_mld(&sdata->vif)); + if (!changed || sdata->vif.type == NL80211_IFTYPE_AP_VLAN) return; @@ -369,7 +371,6 @@ void ieee80211_bss_info_change_notify(struct ieee80211_sub_if_data *sdata, if (changed & ~BSS_CHANGED_VIF_CFG_FLAGS) { u64 ch = changed & ~BSS_CHANGED_VIF_CFG_FLAGS; - /* FIXME: should be for each link */ trace_drv_link_info_changed(local, sdata, &sdata->vif.bss_conf, changed); if (local->ops->link_info_changed) |